lbaas table actions are not implemented well

Bug #1476252 reported by Eric Peterson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Undecided
Eric Peterson

Bug Description

The lbaas table actions all use a post() call with a lot of if/then/else blocks checking the actions. This makes extending this page very tricky, and does not follow documentation and examples / best practices of how to implement table actions in a more flexible / extensible way.

Changed in horizon:
assignee: nobody → Eric Peterson (ericpeterson-l)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/203682

Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/203682
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=eac7d7eab730eeed96635a8fd67016ec0ef93003
Submitter: Jenkins
Branch: master

commit eac7d7eab730eeed96635a8fd67016ec0ef93003
Author: eric <email address hidden>
Date: Mon Jul 20 08:16:37 2015 -0600

    Cleanup lbaas table actions

    The lbaas table actions were not written in a way
    that makes extension or reuse as easy as other tables,
    and has more complex code than is needed. This change
    cleans up this code.

    Change-Id: I7c5f64366b0eaaea91b34fcde2c834ff541c720a
    Closes-Bug: #1476252

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
milestone: none → liberty-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: liberty-3 → 8.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.