fuel-library version of puppetlabs-mongodb is out of sync with the upstream

Bug #1475948 reported by Alex Schultz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Medium
Ivan Berezovskiy

Bug Description

In comparing our mongodb module with the upstream, we have a number of changes from the upstream version.

When comparing 0.10.0 version of the module, here are the files that differ:

 modified: Puppetfile
 deleted: puppet/mongodb/.fixtures.yml
 deleted: puppet/mongodb/.nodeset.yml
 deleted: puppet/mongodb/.travis.yml
 modified: puppet/mongodb/README.md
 modified: puppet/mongodb/lib/puppet/provider/mongodb.rb
 modified: puppet/mongodb/lib/puppet/provider/mongodb_replset/mongo.rb
 modified: puppet/mongodb/lib/puppet/type/mongodb_replset.rb
 modified: puppet/mongodb/manifests/client/install.pp
 modified: puppet/mongodb/manifests/db.pp
 modified: puppet/mongodb/manifests/init.pp
 modified: puppet/mongodb/manifests/mongos/install.pp
 modified: puppet/mongodb/manifests/params.pp
 modified: puppet/mongodb/manifests/server.pp
 modified: puppet/mongodb/manifests/server/config.pp
 modified: puppet/mongodb/manifests/server/install.pp
 modified: puppet/mongodb/manifests/server/service.pp
 modified: puppet/mongodb/spec/classes/server_config_spec.rb
 modified: puppet/mongodb/spec/classes/server_spec.rb
 deleted: puppet/mongodb/templates/mongorc.js.erb

Untracked files:
  (use "git add <file>..." to include in what will be committed)

 puppet/mongodb/checksums.json
 puppet/mongodb/spec/acceptance/nodesets/ubuntu-1204-vcloud.yml
 puppet/mongodb/spec/acceptance/nodesets/ubuntu-1404-vcloud.yml

We should adjust our usage/contribute upstream the differences.

Tags: area-library
Changed in fuel:
status: New → Confirmed
assignee: Fuel Library Team (fuel-library) → Ivan Berezovskiy (iberezovskiy)
Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
Ivan Berezovskiy (iberezovskiy) wrote :

I should propose changes related to retries for MongoDB commands,
Ivan Ponomarev should propose change for replica set refactoring and improvements.

Changed in fuel:
milestone: 7.0 → 8.0
assignee: Ivan Berezovskiy (iberezovskiy) → Ivan Ponomarev (ivanzipfer)
Changed in fuel:
assignee: Ivan Ponomarev (ivanzipfer) → Ivan Berezovskiy (iberezovskiy)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/207512
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=d375befc22a3f173a5dd47b5abc5a19a7ef556ff
Submitter: Jenkins
Branch: master

commit d375befc22a3f173a5dd47b5abc5a19a7ef556ff
Author: iberezovskiy <email address hidden>
Date: Thu Jul 30 18:46:55 2015 +0300

    Improvements for MongoDB replica set configuration

    * Remove upstream pull request which state is uncertain
      https://github.com/puppetlabs/puppetlabs-mongodb/pull/194
    * Move mongorc file creation in openstack class
    * Configure admin user in openstack class
    * Forbid to configure databases and users from slave nodes
      ('if' condition was added defore executing such commands)
    * Remove outdated noop tests
    * Remove useless connection validator because it runs
      during replica creation
      Partial-bug: #1475948

    Fix method which check existing master mongo:
      Closes-bug: #1482154
    It contains a few changes in mongodb module,
    but they will be proposed to upstream according to
    https://bugs.launchpad.net/fuel/+bug/1475948

    Change-Id: I108d2c4a70d5511c5d6601cfdf08191dabb31c1b

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to puppet-modules/puppetlabs-mongodb (0.10.0-mos)

Fix proposed to branch: 0.10.0-mos
Change author: Denis Egorenko <email address hidden>
Review: https://review.fuel-infra.org/11065

Revision history for this message
Ivan Berezovskiy (iberezovskiy) wrote :

Pull request with improvements is here https://github.com/puppetlabs/puppetlabs-mongodb/pull/194

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix merged to puppet-modules/puppetlabs-mongodb (0.10.0-mos)

Reviewed: https://review.fuel-infra.org/11065
Submitter: Ivan Berezovskiy <email address hidden>
Branch: 0.10.0-mos

Commit: 0c1b59ae152f3d4ad1a31dff2ba2457a909c7bbe
Author: Denis Egorenko <email address hidden>
Date: Mon Sep 21 10:44:08 2015

Improvements for MongoDB replica set configuration

* Remove upstream pull request which state is uncertain
  puppetlabs/puppetlabs-mongodb#194
* Move mongorc file creation in openstack class
* Configure admin user in openstack class
* Forbid to configure databases and users from slave nodes
  ('if' condition was added defore executing such commands)
* Remove outdated noop tests
* Remove useless connection validator because it runs
  during replica creation
  Partial-bug: #1475948

Fix method which check existing master mongo:
  Closes-bug: #1482154
It contains a few changes in mongodb module,
but they will be proposed to upstream according to
https://bugs.launchpad.net/fuel/+bug/1475948

Change-Id: I108d2c4a70d5511c5d6601cfdf08191dabb31c1b

Dmitry Pyzhov (dpyzhov)
tags: added: area-library
Revision history for this message
Ivan Berezovskiy (iberezovskiy) wrote :

Patch is merged, need to prepare adapt when mongodb puppet module 0.12.0 will be released

Revision history for this message
Ivan Berezovskiy (iberezovskiy) wrote :

All our custom pacthes are landed in upstream, but 0.12.0 mongodb module isn't released yet. It's too risky to use middle state of this module (between 0.11.0 and 0.12.0), that's why this task should be fixed in 9.0. I guess 0.12.0 will be ready :)

Changed in fuel:
milestone: 8.0 → next
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/281198

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/281198
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=f607d2b9a0d0e42386a84afc3ae0b2e6889edeee
Submitter: Jenkins
Branch: master

commit f607d2b9a0d0e42386a84afc3ae0b2e6889edeee
Author: iberezovskiy <email address hidden>
Date: Wed Feb 17 14:13:12 2016 +0300

    Pull upstream version of mongodb module

    0.12.0 is finally released. Our customization is included
    in it as it was implemented in following pull request:
    https://github.com/puppetlabs/puppetlabs-mongodb/pull/194
    This patch also contains improvements for timeouts during
    replica initialization and user/db creation.

    Additional changes:
      * get rid of useless openstack/mongo class
      * add an ability to configure some mongo parameters
        through hiera
      * move firewall rule to appropriate place

    Closes-bug: #1538521
    Closes-bug: #1475948

    Change-Id: I757b77fcf836f37a8136fa0987cca13ff646712a

Changed in fuel:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.