property should be required argument in unset cmd

Bug #1475872 reported by jiaxi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-openstackclient
Fix Released
Low
jiaxi

Bug Description

The three command line below
openstack volume unset
openstack snapshot unset
openstack volume type unset

They should have --property as a required argument,not optional.
However the doc http://docs.openstack.org/developer/python-openstackclient/command-objects/volume-type.html

The reason is the cmd will not work without --property.
If it's optional, the cmd should work fine without it. But the truth is not.

jiaxi (tjxiter)
Changed in python-openstackclient:
assignee: nobody → jiaxi (tjxiter)
Revision history for this message
Steve Martinelli (stevemar) wrote :

make them required, but keep them in the form of --property.

Changed in python-openstackclient:
status: New → Confirmed
importance: Undecided → Low
jiaxi (tjxiter)
Changed in python-openstackclient:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-openstackclient (master)

Reviewed: https://review.openstack.org/203401
Committed: https://git.openstack.org/cgit/openstack/python-openstackclient/commit/?id=9c95b378323fdc37d403c3757064349c9aaa509b
Submitter: Jenkins
Branch: master

commit 9c95b378323fdc37d403c3757064349c9aaa509b
Author: jiaxi <email address hidden>
Date: Sun Jul 19 02:39:06 2015 -0400

    --property should be required in `os unset` commands

    The three commands below
      openstack volume unset
      openstack snapshot unset
      openstack volume type unset

    Should have --property as a required argument,
    not optional. The reason is the command will not work
    without --property.

    Closes-Bug: #1475872
    Change-Id: Ib9e29392472db38982cc2817af2dd5055f5a01ca

Changed in python-openstackclient:
status: In Progress → Fix Committed
Changed in python-openstackclient:
milestone: none → 1.6.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.