RBAC network support breaks decomposed plugins

Bug #1475837 reported by Gary Kotton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Critical
Gary Kotton

Bug Description

ft1.1586: vmware_nsx.neutron.tests.unit.vmware.test_nsx_v_plugin.TestPortsV2.test_delete_port_public_network_StringException: Empty attachments:
  stderr
  stdout

pythonlogging:'': {{{
2015-07-17 19:35:37,537 INFO [neutron.manager] Loading core plugin: vmware_nsx.neutron.plugins.vmware.plugin.NsxVPlugin
2015-07-17 19:35:37,744 INFO [vmware_nsx.neutron.plugins.vmware.plugins.managers] Configured router type driver names: ['distributed', 'exclusive', 'shared']
2015-07-17 19:35:37,745 INFO [vmware_nsx.neutron.plugins.vmware.plugins.managers] Loaded type driver names: ['exclusive', 'distributed', 'shared']
2015-07-17 19:35:37,745 INFO [vmware_nsx.neutron.plugins.vmware.plugins.managers] Registered types: ['exclusive', 'distributed', 'shared']
2015-07-17 19:35:37,745 INFO [vmware_nsx.neutron.plugins.vmware.plugins.managers] Tenant router_types: ['shared', 'distributed', 'exclusive']
2015-07-17 19:35:37,745 INFO [neutron.manager] Service L3_ROUTER_NAT is supported by the core plugin
2015-07-17 19:35:37,756 ERROR [neutron.api.extensions] Extension path 'neutron/tests/unit/extensions' doesn't exist!
2015-07-17 19:35:37,761 ERROR [neutron.api.extensions] Extension path 'neutron/tests/unit/extensions' doesn't exist!
2015-07-17 19:35:37,762 WARNING [neutron.notifiers.nova] Authenticating to nova using nova_admin_* options is deprecated. This should be done using an auth plugin, like password
2015-07-17 19:35:37,763 WARNING [neutron.quota] subnet is already registered.
2015-07-17 19:35:37,764 WARNING [neutron.notifiers.nova] Authenticating to nova using nova_admin_* options is deprecated. This should be done using an auth plugin, like password
2015-07-17 19:35:37,765 WARNING [neutron.quota] subnetpool is already registered.
2015-07-17 19:35:37,765 WARNING [neutron.notifiers.nova] Authenticating to nova using nova_admin_* options is deprecated. This should be done using an auth plugin, like password
2015-07-17 19:35:37,767 WARNING [neutron.quota] network is already registered.
2015-07-17 19:35:37,767 WARNING [neutron.notifiers.nova] Authenticating to nova using nova_admin_* options is deprecated. This should be done using an auth plugin, like password
2015-07-17 19:35:37,768 WARNING [neutron.quota] port is already registered.
2015-07-17 19:35:37,889 INFO [vmware_nsx.neutron.plugins.vmware.plugins.nsx_v] Added {'sg_id': '0', 'vnic_id': '1'}(sg_id)s member to NSX security group 1
2015-07-17 19:35:37,934 ERROR [neutron.api.v2.resource] create failed
Traceback (most recent call last):
  File "/home/jenkins/workspace/gate-vmware-nsx-python27/.tox/py27/src/neutron/neutron/api/v2/resource.py", line 83, in resource
    result = method(request=request, **args)
  File "/home/jenkins/workspace/gate-vmware-nsx-python27/.tox/py27/local/lib/python2.7/site-packages/oslo_db/api.py", line 146, in wrapper
    ectxt.value = e.inner_exc
  File "/home/jenkins/workspace/gate-vmware-nsx-python27/.tox/py27/local/lib/python2.7/site-packages/oslo_utils/excutils.py", line 119, in __exit__
    six.reraise(self.type_, self.value, self.tb)
  File "/home/jenkins/workspace/gate-vmware-nsx-python27/.tox/py27/local/lib/python2.7/site-packages/oslo_db/api.py", line 136, in wrapper
    return f(*args, **kwargs)
  File "/home/jenkins/workspace/gate-vmware-nsx-python27/.tox/py27/src/neutron/neutron/api/v2/base.py", line 412, in create
    item[self._resource])
  File "/home/jenkins/workspace/gate-vmware-nsx-python27/.tox/py27/src/neutron/neutron/api/v2/base.py", line 690, in _validate_network_tenant_ownership
    resource_item['network_id'])
  File "vmware_nsx/neutron/plugins/vmware/plugins/nsx_v.py", line 733, in get_network
    net_result = self._make_network_dict(network)
  File "/home/jenkins/workspace/gate-vmware-nsx-python27/.tox/py27/src/neutron/neutron/db/db_base_plugin_common.py", line 228, in _make_network_dict
    entry.target_tenant in ('*', context.tenant_id)):
AttributeError: 'NoneType' object has no attribute 'tenant_id'
}}}

pythonlogging:'neutron.api.extensions': {{{
2015-07-17 19:35:37,756 ERROR [neutron.api.extensions] Extension path 'neutron/tests/unit/extensions' doesn't exist!
2015-07-17 19:35:37,761 ERROR [neutron.api.extensions] Extension path 'neutron/tests/unit/extensions' doesn't exist!
}}}

Traceback (most recent call last):
  File "/home/jenkins/workspace/gate-vmware-nsx-python27/.tox/py27/src/neutron/neutron/tests/unit/db/test_db_base_plugin_v2.py", line 1184, in test_delete_port_public_network
    set_context=True)
  File "/home/jenkins/workspace/gate-vmware-nsx-python27/.tox/py27/src/neutron/neutron/tests/unit/db/test_db_base_plugin_v2.py", line 398, in _create_port
    self.assertEqual(port_res.status_int, expected_res_status)
  File "/home/jenkins/workspace/gate-vmware-nsx-python27/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py", line 350, in assertEqual
    self.assertThat(observed, matcher, message)
  File "/home/jenkins/workspace/gate-vmware-nsx-python27/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py", line 435, in assertThat
    raise mismatch_error
testtools.matchers._impl.MismatchError: 500 != 201

Gary Kotton (garyk)
Changed in neutron:
importance: Undecided → Critical
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/203326

Changed in neutron:
assignee: nobody → Gary Kotton (garyk)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/203326
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=ce437729f9ac552939c5473c8c8fee52d214c8db
Submitter: Jenkins
Branch: master

commit ce437729f9ac552939c5473c8c8fee52d214c8db
Author: Gary Kotton <email address hidden>
Date: Sat Jul 18 00:33:10 2015 -0700

    Validate that context exists

    Commit 3e0328b992d8a90213a56ec5a4144677279bea66 broke external
    decomposed plugins due to the fact that it assumes that the
    context is set.

    This patch validates that the context is set.

    Co-Authored-By: Kevin Benton <email address hidden>

    Change-Id: I3320f27be7b0fed1d3b37a5c5459d91b2bc4f13b
    Closes-bug: #1475837

Changed in neutron:
status: In Progress → Fix Committed
Changed in neutron:
milestone: none → liberty-2
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (feature/pecan)

Fix proposed to branch: feature/pecan
Review: https://review.openstack.org/207903

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (feature/pecan)
Download full text (70.7 KiB)

Reviewed: https://review.openstack.org/207903
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=9badcd249dab2d3330f0cd608496b59c9f44499a
Submitter: Jenkins
Branch: feature/pecan

commit 991ea00e6c115343eabecc62e86072175823f81f
Author: Moshe Levi <email address hidden>
Date: Thu Jul 30 12:04:15 2015 +0300

    SR-IOV: Fix SR-IOV agent to run ip link commands as root

    Commit https://review.openstack.org/#/c/155523/
    remove the remaining root_helper args, but didn't
    update the SR-IOV agent to execute them as root.

    This patch updates the agent to execute ip link commands
    as root and pass options argument as a list in the
    self._as_root method.

    Closes-Bug: #1479694
    Change-Id: I53cafd61845a69fae3a759fb7526950d655ffa20

commit 5b3bacedf6c014815bef03c2e821b5eb8ef92dcb
Author: Saksham Varma <email address hidden>
Date: Thu Jul 23 22:46:23 2015 -0700

    Moved out cisco n1kv mech driver and db models

    Moving out Cisco N1Kv database models and the mech driver
    to the openstack/networking-cisco repo as part of the second
    phase vendor-core decomposition

    Partial-Bug: #1479123
    Partial-implements: blueprint core-vendor-decomposition

    Change-Id: I65a704b238d8cbe2951a6912fa4f1e8518c6f412

commit 65ac8cd0a80548e115b8ec1d4cfd47a94422fddf
Author: OpenStack Proposal Bot <email address hidden>
Date: Wed Jul 29 20:44:01 2015 +0000

    Updated from global requirements

    Change-Id: I3a884a73d51df0f93b5cc88b3e3250d81bb1f455

commit f0e8356d04d04600c072a1c0f0bdf274ff19ab8c
Author: sridhargaddam <email address hidden>
Date: Mon Jul 27 03:46:48 2015 +0000

    Update dhcp agent cache for network:dhcp ports

    When a network with a dhcp_enabled subnet is scheduled on a dhcp
    agent, dhcp driver creates the network:dhcp port for the subnet.
    However, the port info is not updated in dhcp agents internal cache.
    Subsequently if the user deletes the network:dhcp port, the port is
    properly deleted on the server side (i.e., in the database) and when
    the port_delete_end notification is sent to the dhcp agent, it simply
    ignores it as the port entry would be missing in the cache. This patch
    fixes this issue by updating the dhcp agents cache when dhcp driver
    creates the network:dhcp port for the subnets.

    Closes-Bug: #1478426
    Change-Id: I69f5834dd964a4320c606c4e0aa2cdba70416943

commit cb60d0bb4e0cc0cba68f59fdf5f4e89d6ec52950
Author: changzhi <email address hidden>
Date: Thu Jul 16 10:14:16 2015 +0800

    Keep dns nameserver order consistency

    Currently, there is no dns servers prioritization for subnets
    for Neutron.

    Generally speaking, it is useful to keep the order of dns
    nameservers consistent. Add a new column named 'order' in table
    'dnsnameservers' and add nameserver into DB one by one.

    Closes-Bug: #1218629
    Implements: blueprint keep-dns-nameserver-orderconsistency
    Change-Id: Id937aea411397d39370368a4eb45be26c4eefa9e

commit b39e1469e824bc8bc79e1ecafa98825a94811c0b
Author: Salvatore Orlando <email address hidden>
Date: Tue Jun 23 04:54:2...

tags: added: in-feature-pecan
Thierry Carrez (ttx)
Changed in neutron:
milestone: liberty-2 → 7.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.