Late Night Skin - Changing musical key by clicking in interface

[Raf Van De Meirssche]

This is ONLY in the LateNight skin.
Deere and Shade function as I suppose they should.

Build 1.12 r5481.
Both Ubuntu 14.04 LTS 64-bit and Windows 7 Home Premium 64-bit.

When I press one of the little triangular arrows next to the KEY button, I see no change.
I have to press the button 4 times before I see the key notation change.

I am not a musician and do not have that musical ear, but I think the musical key doesn't change either before that 4th press.
This is for your information, because I suppose that changing by a quarter of a tone has little sense.
But then again ... I'm not a musician.

On the other hand ... Deere and Shade do change on first instance as I would expect it to do.
(One was a knob, don't remember which)

[jus (jus)]

This is because the skin uses the ``pitch_down_small`` & ``pitch_up_small`` controls for the buttons, which changes the key only by a tiny amount. The following allows audible changes on click, and small changes on right-click:

https://github.com/mixxxdj/mixxx/blob/master/res/skins/LateNight/deck.xml#L35 ff.
and
https://github.com/mixxxdj/mixxx/blob/master/res/skins/LateNight/deck.xml#L79 ff.
replace with

<Connection>
  <ConfigKey persist="true">[Channel<Variable name="channum"/>],pitch_down</ConfigKey>
  <ButtonState>LeftButton</ButtonState>
</Connection>
<Connection>
  <ConfigKey persist="true">[Channel<Variable name="channum"/>],pitch_down_small</ConfigKey>
  <ButtonState>RightButton</ButtonState>
</Connection>

[jus (jus)]

geez, you still cant edit comments on lauchpad.

Of course you need a different pair of controls for https://github.com/mixxxdj/mixxx/blob/master/res/skins/LateNight/deck.xml#L79 ff.
<Connection>
  <ConfigKey persist="true">[Channel<Variable name="channum"/>],pitch_up</ConfigKey>
  <ButtonState>LeftButton</ButtonState>
</Connection>
<Connection>
  <ConfigKey persist="true">[Channel<Variable name="channum"/>],pitch_up_small</ConfigKey>
  <ButtonState>RightButton</ButtonState>
</Connection>

[jus (jus)]

https://github.com/mixxxdj/mixxx/commit/67c4a248073ee9089c48ba02843e22d739056001

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/8157