DM: should configure AS number for eBGP peers

[amit surana]

DM is not setting the peer-as number for eBGP peers. For each external neighbor, the following should be pushed:

set groups __contrail__ protocols bgp group __contrail_external__ neighbor <> peer-as <>

current config:

group __contrail_external__ {
    type external;
    multihop;
    local-address 11.1.10.1;
    hold-time 90;
    keep all;
    family inet-vpn {
        unicast;
    }
    family inet6-vpn {
        unicast;
    }
    family evpn {
        signaling;
    }
    family route-target;
    neighbor 11.1.4.2 {
        family inet-vpn {
            unicast;
        }
        family inet6-vpn {
            unicast;
        }
        family evpn {
            signaling;
        }
        family route-target;
    }
}

[edit]
root@bali# commit check
[edit groups __contrail__ protocols]
  'bgp'
    Error in neighbor 11.1.4.2 of group __contrail_external__:
peer AS number must be configured for an external peer
error: configuration check-out failed

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/12455
Submitter: Suresh Balineni (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/12456
Submitter: Suresh Balineni (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/12455
Submitter: Suresh Balineni (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/12456
Committed: http://github.org/Juniper/contrail-controller/commit/197c30729d2c6854b106f92e6c668e1db3f3e5b3
Submitter: Zuul
Branch: master

commit 197c30729d2c6854b106f92e6c668e1db3f3e5b3
Author: sbalineni <email address hidden>
Date: Thu Jul 16 14:44:34 2015 -0700

DM: Fix for configuring ebgp AS attribute, irb GW address

Currently DM is mistakenly looking for AS value in
session parameters, instead it should find it in
Router Params list.

Also fixes the issue of hard coded prefix len of IRB GW address

Change-Id: Ie83427d9fd923d1592c6536532836bf9dc542b15
Closes-Bug: #1475365
Closes-Bug: #1475452

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/12455
Committed: http://github.org/Juniper/contrail-controller/commit/0597f5225609cf00c3374ece5bdcdebce9787b49
Submitter: Zuul
Branch: R2.20

commit 0597f5225609cf00c3374ece5bdcdebce9787b49
Author: sbalineni <email address hidden>
Date: Thu Jul 16 14:37:59 2015 -0700

DM: Fix for configuring ebgp AS attribute, irb gw addr

Currently DM is mistakenly looking for AS value in
session parameters, instead it should find it in
Router Params list.

Also fixes the issue of hard coded irb gateway address

Closes-Bug: #1475365
Closes-Bug: #1475452

Change-Id: I1c77829ccb0093d697bb53aa3d93d17b7b88aafa

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/13927
Submitter: Vinay Vithal Mahuli (<email address hidden>)