Warning on galera playbook run

Bug #1475328 reported by Andy McCrae
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack-Ansible
Fix Released
Low
Andy McCrae
Kilo
Fix Released
Low
Jesse Pretorius
Trunk
Fix Released
Low
Andy McCrae

Bug Description

[WARNING]: It is unnecessary to use '{{' in conditionals, leave variables in loop expressions bare.

This seems to be because the "with_items" and "when" have "{{ }}" around the variable which isn't required.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-ansible-deployment (master)

Fix proposed to branch: master
Review: https://review.openstack.org/202581

Changed in openstack-ansible:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-ansible-deployment (master)

Reviewed: https://review.openstack.org/202581
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=57577bb369a107ed704f4791090b1c810599258c
Submitter: Jenkins
Branch: master

commit 57577bb369a107ed704f4791090b1c810599258c
Author: Andy McCrae <email address hidden>
Date: Thu Jul 16 15:09:41 2015 +0100

    Remove {{ from "with_items" and "when" statements

    This patch resolves a minor issue that was generating a "warning"
    message when running the galera-install.yml playbook.

    The "{{" and "}}" are not required for conditionals, and loop
    expressions, so these can and should safely be removed from "when:"
    statements and "with_items:" statements.

    Functionality does not change but the warning message will go away after
    this patch.

    Change-Id: I3e9d3a4afb0e3d1284c78a37dba6d1534154a063
    Closes-Bug: #1475328

Changed in openstack-ansible:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-ansible-deployment (kilo)

Fix proposed to branch: kilo
Review: https://review.openstack.org/207175

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-ansible-deployment (kilo)

Reviewed: https://review.openstack.org/207175
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=bb311acfc58672d70a32c38100cad93a7b9401e0
Submitter: Jenkins
Branch: kilo

commit bb311acfc58672d70a32c38100cad93a7b9401e0
Author: Andy McCrae <email address hidden>
Date: Thu Jul 16 15:09:41 2015 +0100

    Remove {{ from "with_items" and "when" statements

    This patch resolves a minor issue that was generating a "warning"
    message when running the galera-install.yml playbook.

    The "{{" and "}}" are not required for conditionals, and loop
    expressions, so these can and should safely be removed from "when:"
    statements and "with_items:" statements.

    Functionality does not change but the warning message will go away after
    this patch.

    Change-Id: I3e9d3a4afb0e3d1284c78a37dba6d1534154a063
    Closes-Bug: #1475328
    (cherry picked from commit 57577bb369a107ed704f4791090b1c810599258c)

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/openstack-ansible 11.2.11

This issue was fixed in the openstack/openstack-ansible 11.2.11 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/openstack-ansible 11.2.12

This issue was fixed in the openstack/openstack-ansible 11.2.12 release.

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/openstack-ansible 11.2.14

This issue was fixed in the openstack/openstack-ansible 11.2.14 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.