Not informative error message while making package public if package with the same FQPN already public by other tenant

Bug #1475079 reported by Victor Ryzhenkin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Fix Released
Medium
Lin Yang

Bug Description

Steps:
1. Log into horizon.
2. Upload murano-app(Apache, for example)
3. Make this app public
4. Change tenant.
5. Upload the same app.
6. Try to make app public

Actual:
Error: Unable to toggle public: Apache HTTP Server

Expected:
Correct reason, why user can't make app public

Tags: ux
tags: added: ux
Changed in murano:
status: New → Triaged
summary: - It's impossible to make package public if package with the same FQPN
- already public by other tenant
+ Not informative error message while making package public if package
+ with the same FQPN already public by other tenant
Lin Yang (lin-a-yang)
Changed in murano:
assignee: nobody → Lin Yang (lin-a-yang)
Changed in murano:
milestone: liberty-3 → liberty-rc1
Changed in murano:
status: Triaged → Confirmed
Revision history for this message
Kirill Zaitsev (kzaitsev) wrote :

There seem to be 2 cases: 1) another package with such fqn is already public 2) not enough permissions.

Lin Yang (lin-a-yang)
Changed in murano:
status: Confirmed → In Progress
Revision history for this message
Lin Yang (lin-a-yang) wrote :

For the first case, when another package with such fqn is already public, API will return correct message like below.

"Class with the same full name is already registered in the visibility scope"

But dashboard didn't show this message back to user.

Changed in murano:
milestone: liberty-rc1 → mitaka-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano-dashboard (master)

Fix proposed to branch: master
Review: https://review.openstack.org/235786

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano-dashboard (master)

Reviewed: https://review.openstack.org/235786
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=a4c7558519e4f9f8fa41f67225e195bbf3e10045
Submitter: Jenkins
Branch: master

commit a4c7558519e4f9f8fa41f67225e195bbf3e10045
Author: Lin Yang <email address hidden>
Date: Fri Oct 16 16:44:28 2015 +0800

    Improve message for publish package conflict

    When user publish a package conflict with another public package with same FQN,
    API server will throw webob.exc.HTTPConflict. So catch the exception on
    dashboard and give back a specific reason to user.

    Change-Id: I3cd7ea24c6645487e6c7155a1f530c64f31bd332
    Closes-Bug: #1475079
    Co-authored-by: zhu.rong <zhu.rong@99cloud.net>

Changed in murano:
status: In Progress → Fix Committed
Changed in murano:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.