Modal service is incorrectly named

Bug #1475046 reported by Thai Tran
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Thai Tran

Bug Description

Currently, the simple modal service is named "modal.service.js". This is incorrect, the file name should be "simple-modal.service.js" or something similar. Why do we care about a rename? We will likely introduce other modal services in the near future (i.e. wizard-modal.service). Leaving it as is leaves room for naming collision.

Link to the modal module:
https://github.com/openstack/horizon/tree/1791ae066e1f769f385648282793407cc7749702/horizon/static/framework/widgets/modal

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/202328

Changed in horizon:
assignee: nobody → Thai Tran (tqtran)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/202328
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=3f83aef2970adecd746631c6640a8da975dad330
Submitter: Jenkins
Branch: master

commit 3f83aef2970adecd746631c6640a8da975dad330
Author: Thai Tran <email address hidden>
Date: Wed Jul 15 16:19:07 2015 -0700

    Modal service is incorrectly named

    Currently, the simple modal service is named "modal.service.js". This is
    incorrect, the file name should be "simple-modal.service.js".
    Also fixed linting issues.

    Why do we care about a rename?
    Leaving it as is leaves room for naming collision.
    We will likely introduce other modal services in the near future
    (for example, the wizard-modal.service)

    Change-Id: I61b9c93f37adf0004e99970cf9194ba4fd22eb00
    Closes-Bug: #1475046

Changed in horizon:
status: In Progress → Fix Committed
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: liberty-2 → 8.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.