framework.module.js contains app specific logic

Bug #1474998 reported by Tyr Johanson
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
New
Low
Unassigned

Bug Description

framework.module.js is the root module for application agnostic, reusable horizon componenents. It currently contains "frameworkConfiguration" which is config logic that is specific to a particular application (openstack_dashboard), such as the default interpolator, at the HTTP 401 response interceptor.

Move the interceptor at least (and possibly the default interpolator) to openstack_dashboard/static/app/app.module.js which is the correct spot to configuration application specific behavior.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/203832

Changed in horizon:
assignee: nobody → Tyr Johanson (tyr-6)
status: New → In Progress
Changed in horizon:
assignee: Tyr Johanson (tyr-6) → Travis Tripp (travis-tripp)
Changed in horizon:
assignee: Travis Tripp (travis-tripp) → Shaoquan Chen (sean-chen2)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by David Lyle (<email address hidden>) on branch: master
Review: https://review.openstack.org/203832
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Revision history for this message
Gary W. Smith (gary-w-smith) wrote :

Unsassigning due to inactivity

Changed in horizon:
assignee: Shaoquan Chen (sean-chen2) → nobody
importance: Undecided → Low
status: In Progress → New
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.