swift-rings.py has some unused functions

Bug #1474334 reported by Andy McCrae
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack-Ansible
Fix Released
Low
Andy McCrae
Kilo
Fix Released
Low
Jesse Pretorius
Trunk
Fix Released
Low
Andy McCrae

Bug Description

The following 2 functions are not used and only call eachother:

def has_section(conf, section):
    return True if conf.get(section) else False

def check_section(conf, section):
    if not has_section(conf, section):
        print("Section %s doesn't exist" % section)
        sys.exit(2)

They should be removed for the sake of clarity.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-ansible-deployment (master)

Fix proposed to branch: master
Review: https://review.openstack.org/201531

Changed in openstack-ansible:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-ansible-deployment (master)

Reviewed: https://review.openstack.org/201531
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=8d65120e34d0d0307080c276c944c4d3d3e83f2f
Submitter: Jenkins
Branch: master

commit 8d65120e34d0d0307080c276c944c4d3d3e83f2f
Author: Andy McCrae <email address hidden>
Date: Tue Jul 14 13:06:31 2015 +0100

    Cleanup unused functions in swift_rings.py

    Removes 2 unused functions in swift_rings.py (check_section &
    has_section), these are not called at all and should be removed for
    clarity.

    Change-Id: Id56654df92834f7a48ce21e70b372f04e920653e
    Closes-Bug: #1474334

Changed in openstack-ansible:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-ansible-deployment (kilo)

Fix proposed to branch: kilo
Review: https://review.openstack.org/207174

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-ansible-deployment (kilo)

Reviewed: https://review.openstack.org/207174
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=d87634a660625fad2984490b0cf1f3a3066bc195
Submitter: Jenkins
Branch: kilo

commit d87634a660625fad2984490b0cf1f3a3066bc195
Author: Andy McCrae <email address hidden>
Date: Tue Jul 14 13:06:31 2015 +0100

    Cleanup unused functions in swift_rings.py

    Removes 2 unused functions in swift_rings.py (check_section &
    has_section), these are not called at all and should be removed for
    clarity.

    Change-Id: Id56654df92834f7a48ce21e70b372f04e920653e
    Closes-Bug: #1474334
    (cherry picked from commit 8d65120e34d0d0307080c276c944c4d3d3e83f2f)

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/openstack-ansible 11.2.11

This issue was fixed in the openstack/openstack-ansible 11.2.11 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/openstack-ansible 11.2.12

This issue was fixed in the openstack/openstack-ansible 11.2.12 release.

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/openstack-ansible 11.2.14

This issue was fixed in the openstack/openstack-ansible 11.2.14 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.