py26 tests are broken

Bug #1474261 reported by Julia Varlamova
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-manilaclient
Fix Released
High
Julia Varlamova

Bug Description

We get an error while running py26 tests: Mock version seems to be incompatible with py26.

Traceback (most recent call last):
2015-07-14 08:38:25.999 | File ".tox/py26/bin/testr", line 26, in <module>
2015-07-14 08:38:26.000 | sys.exit(run_argv(sys.argv, sys.stdin, sys.stdout, sys.stderr))
2015-07-14 08:38:26.000 | File "/home/jenkins/workspace/gate-python-manilaclient-python26/.tox/py26/lib/python2.6/site-packages/testrepository/commands/__init__.py", line 184, in run_argv
2015-07-14 08:38:26.000 | cmdclass = _find_command(cmd_name)
2015-07-14 08:38:26.001 | File "/home/jenkins/workspace/gate-python-manilaclient-python26/.tox/py26/lib/python2.6/site-packages/testrepository/commands/__init__.py", line 51, in _find_command
2015-07-14 08:38:26.001 | _temp = __import__(modname, globals(), locals(), [classname])
2015-07-14 08:38:26.033 | File "/home/jenkins/workspace/gate-python-manilaclient-python26/.tox/py26/lib/python2.6/site-packages/testrepository/commands/last.py", line 22, in <module>
2015-07-14 08:38:26.035 | from testrepository.testcommand import TestCommand
2015-07-14 08:38:26.035 | File "/home/jenkins/workspace/gate-python-manilaclient-python26/.tox/py26/lib/python2.6/site-packages/testrepository/testcommand.py", line 35, in <module>
2015-07-14 08:38:26.035 | from fixtures import Fixture
2015-07-14 08:38:26.036 | File "/home/jenkins/workspace/gate-python-manilaclient-python26/.tox/py26/lib/python2.6/site-packages/fixtures/__init__.py", line 87, in <module>
2015-07-14 08:38:26.036 | from fixtures._fixtures import (
2015-07-14 08:38:26.036 | File "/home/jenkins/workspace/gate-python-manilaclient-python26/.tox/py26/lib/python2.6/site-packages/fixtures/_fixtures/__init__.py", line 55, in <module>
2015-07-14 08:38:26.036 | from fixtures._fixtures.mockpatch import (
2015-07-14 08:38:26.036 | File "/home/jenkins/workspace/gate-python-manilaclient-python26/.tox/py26/lib/python2.6/site-packages/fixtures/_fixtures/mockpatch.py", line 22, in <module>
2015-07-14 08:38:26.037 | mock = extras.try_imports(['unittest.mock', 'mock'], None)
2015-07-14 08:38:26.037 | File "/home/jenkins/workspace/gate-python-manilaclient-python26/.tox/py26/lib/python2.6/site-packages/extras/__init__.py", line 87, in try_imports
2015-07-14 08:38:26.037 | module = try_import(module_name, error_callback=error_callback)
2015-07-14 08:38:26.037 | File "/home/jenkins/workspace/gate-python-manilaclient-python26/.tox/py26/lib/python2.6/site-packages/extras/__init__.py", line 46, in try_import
2015-07-14 08:38:26.038 | module = __import__(module_name)
2015-07-14 08:38:26.038 | File "/home/jenkins/workspace/gate-python-manilaclient-python26/.tox/py26/lib/python2.6/site-packages/mock/__init__.py", line 2, in <module>
2015-07-14 08:38:26.038 | import mock.mock as _mock
2015-07-14 08:38:26.038 | File "/home/jenkins/workspace/gate-python-manilaclient-python26/.tox/py26/lib/python2.6/site-packages/mock/mock.py", line 132
2015-07-14 08:38:26.039 | _builtins = {name for name in dir(builtins) if not name.startswith('_')}
2015-07-14 08:38:26.040 | ^
2015-07-14 08:38:26.040 | SyntaxError: invalid syntax

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-manilaclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/201463

Changed in python-manilaclient:
assignee: nobody → Julia Varlamova (jvarlamova)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-manilaclient (master)

Change abandoned by Julia Varlamova (<email address hidden>) on branch: master
Review: https://review.openstack.org/201463

Changed in python-manilaclient:
assignee: Julia Varlamova (jvarlamova) → nobody
Revision history for this message
Julia Varlamova (jvarlamova) wrote :

Fix is already on review in manilaclient: https://review.openstack.org/#/c/200906/

Changed in python-manilaclient:
assignee: nobody → Julia Varlamova (jvarlamova)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-manilaclient (master)

Reviewed: https://review.openstack.org/201481
Committed: https://git.openstack.org/cgit/openstack/python-manilaclient/commit/?id=2a4f79cc0d3e38a3077980da404695a62319520e
Submitter: Jenkins
Branch: master

commit 2a4f79cc0d3e38a3077980da404695a62319520e
Author: Julia Varlamova <email address hidden>
Date: Tue Jul 14 06:02:15 2015 -0400

    Fix post_test_hook and update test-requirements

    Our gate jobs are broken in two places:

        - latest mock lib does not work on py26;
        - post_test_hook.sh is not compatible with devstack anymore after change to devstack [1]

    So, fix post_test_hook.sh and set proper version to mock lib.

    [1]: I613f1bdc6673f0c4bfe29aaab7b514348a617a8c

    Closes-Bug: #1474293
    Closes-Bug: #1474261
    Closes-Bug: #1474744

    Change-Id: Ia849a06275e738078dc4543680d499c6149117d5

Changed in python-manilaclient:
status: In Progress → Fix Committed
Changed in python-manilaclient:
importance: Undecided → High
Changed in python-manilaclient:
milestone: none → 1.3.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.