Floating IP cannot be assigned if instance joins an existing network but not the env's default

[Alexander Tivelkov]

If the Instance joins an existing network without joining an environment's default network, it may not be assigned a floating IP address.

This happens because fip assignment requires a so-called "primary network" which get automatically resolved as "either a default environment's network or a flat network is the former is not assigned".

If neither environment's default nor flat networks are assigned for the instance, but some custom networks are present, some of them should be chosen as "primary", however this does not happen.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/201304

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/201304
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=315c7a1216baa598b86a26d7b16329635cc704cd
Submitter: Jenkins
Branch: master

commit 315c7a1216baa598b86a26d7b16329635cc704cd
Author: Alexander Tivelkov <email address hidden>
Date: Mon Jul 13 22:26:31 2015 +0300

    Use Custom networks as primary if no others exist

    Modify the logic of primary network detection, so if the instance does
    not join environment's default of flat networks, but some custom
    networks are passed, the first of them is used as a primary one.

    This fixes the issue when the floating ip address could not be assigned
    in case of custom networking configuration.

    Change-Id: Ief8819fd24695aceb118862839301b8045c41ea4
    Closes-bug: #1474092