Seeking HE-AAC files fails

Bug #1473690 reported by Neale Pickett
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
High
Neale Pickett

Bug Description

HE-AAC files use 2048 frames per sample block; soundsourcem4a.cpp is currently hard-coded to assume 1024. Files will play if started from offset 0, but seeking anywhere in an HE-AAC file starts spewing errors and won't output any sound. In addition, it appears track time is calculated to be half what it should be.

The patch at https://github.com/mixxxdj/mixxx/pull/643 changed Mixxx to refuse to load HE-AAC files.

Revision history for this message
Neale Pickett (neale) wrote :

I just commited another patch in that branch that will load the files. I've tested with several of the files that were problematic before, and everything is fine: random seeks and track duration in particular are both fixed now.

Changed in mixxx:
assignee: nobody → Neale Pickett (neale)
status: New → In Progress
importance: Undecided → High
milestone: none → 2.1
Revision history for this message
Neale Pickett (neale) wrote :

Patch accepted to trunk. I've verified at several live gigs that it works just splendidly.

Changed in mixxx:
status: In Progress → Fix Committed
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/8145

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.