Missing variables from Juno to Kilo upgrade

[Bjoern]

The run_upgrade.sh bailed out with

TASK: [galera_client | Drop local .my.cnf file] *******************************
fatal: [617564-infra03_galera_container-9eb3fbb0] => {'msg': "AnsibleUndefinedVariable: One or more undefined variables: 'galera_root_password' is undefined", 'failed': True}
fatal: [617564-infra03_galera_container-9eb3fbb0] => {'msg': "AnsibleUndefinedVariable: One or more undefined variables: 'galera_root_password' is undefined", 'failed': True}
fatal: [617563-infra02_galera_container-96f84347] => {'msg': "AnsibleUndefinedVariable: One or more undefined variables: 'galera_root_password' is undefined", 'failed': True}
fatal: [617563-infra02_galera_container-96f84347] => {'msg': "AnsibleUndefinedVariable: One or more undefined variables: 'galera_root_password' is undefined", 'failed': True}
fatal: [617562-infra01_galera_container-1a0b344b] => {'msg': "AnsibleUndefinedVariable: One or more undefined variables: 'galera_root_password' is undefined", 'failed': True}
fatal: [617562-infra01_galera_container-1a0b344b] => {'msg': "AnsibleUndefinedVariable: One or more undefined variables: 'galera_root_password' is undefined", 'failed': True}

please add the variable to the user_config

[Bjoern (bjoern-t)]

Submitted patch for master branch https://review.openstack.org/#/c/200721/

[Nolan Brubaker (nolan-brubaker)]

Re-checking the code, I found this:

https://github.com/stackforge/os-ansible-deployment/blob/kilo/scripts/run-upgrade.sh#L211

Since it's a secret, the value should be in user_secrets.yml, and it should already be managed.

[Nolan Brubaker (nolan-brubaker)]

Was this failure on juno to head of kilo, or juno to head of master?

[Bjoern (bjoern-t)]

I did try the 11.0.4 tag but let's close the issue since the run_upgrade.sh bailed and some steps like the sed from mysql to galera might have been skipped.

[Nolan Brubaker (nolan-brubaker)]

Ok, will do.

Also, just to be sure, I tested on 10.1.10 to head of kilo (SHA 221daab63f6a1d2032eddb132cf25846f3d893ec) and found that the value was present in /etc/openstack_deploy/user_secrets.yml.

I did not try 10.1.10 -> 11.0.4 yet.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Nolan Brubaker (<email address hidden>) on branch: master
Review: https://review.openstack.org/200721
Reason: Abandoning since reporter closed bug as invalid, and the galera_root_password value is actually written to user_secrets.yml, not user_variables.yml.