Limit Summary template refactor prevents translators from controlling the word order in translations

Bug #1473541 reported by Akihiro Motoki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
KATO Tomoyuki

Bug Description

As a result of the change of https://review.openstack.org/#/c/170147,
translators cannot control word order any more.
It stops using blocktrans and uses string concatenation instead.

The limit template is used in the top page, and Horizon provides ugly strings in Overview of the top page.

Tags: i18n
Akihiro Motoki (amotoki)
Changed in horizon:
milestone: none → liberty-3
summary: - Limit Summary template refator prevents translators from controlling the
- word order in translations
+ Limit Summary template refactor prevents translators from controlling
+ the word order in translations
Revision history for this message
KATO Tomoyuki (kato-tomoyuki) wrote :

This is a very important feature for translators, include me.

However, in my understand,

* other block tags (for example {% blocktrans %}, except for elif and else ) are not allowed inside a if tag [1],
* and other block tags (for example {% for %} or {% if %}) are not allowed inside a blocktrans tag [2].

So, I think we need think this over.

[1]: https://docs.djangoproject.com/en/1.8/ref/templates/builtins/#if
[2]: https://docs.djangoproject.com/en/1.8/topics/i18n/translation/#std:templatetag-blocktrans

Revision history for this message
KATO Tomoyuki (kato-tomoyuki) wrote :

let me make correction.

We can use a blocktrans tag inside a if tag.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/214951

Changed in horizon:
assignee: nobody → KATO Tomoyuki (kato-tomoyuki)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/214951
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=11887865e9f8ef819cb33bfe1657289b187a3494
Submitter: Jenkins
Branch: master

commit 11887865e9f8ef819cb33bfe1657289b187a3494
Author: KATO Tomoyuki <email address hidden>
Date: Thu Aug 20 14:12:10 2015 +0900

    Use a blocktrans tag in limit summary template

    * No additional feature
    * Enable translators to control word order

    Change-Id: I8c1af69596ba668c09990e41d8d58d2df450d6d2
    Closes-Bug: #1473541

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: liberty-3 → 8.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.