gate-nova-python27 and gate-nova-docs failing for mock 1.1.0

Bug #1473401 reported by Ghanshyam Mann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Critical
Sean Dague
PBR
Fix Released
High
Monty Taylor
Tags: testing
Changed in nova:
assignee: nobody → Ghanshyam Mann (ghanshyammann)
Changed in nova:
assignee: Ghanshyam Mann (ghanshyammann) → nobody
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/200500

Changed in nova:
assignee: nobody → Ghanshyam Mann (ghanshyammann)
status: New → In Progress
Matt Riedemann (mriedem)
tags: added: testing
Changed in nova:
importance: Undecided → High
Changed in nova:
assignee: Ghanshyam Mann (ghanshyammann) → Sean Dague (sdague)
Revision history for this message
Matt Riedemann (mriedem) wrote : Re: Nova unit tests failing for mock 1.1.0
Matt Riedemann (mriedem)
Changed in nova:
importance: High → Critical
Matt Riedemann (mriedem)
summary: - Nova unit tests failing for mock 1.1.0
+ gate-nova-python27 and gate-nova-docs failing for mock 1.1.0
Revision history for this message
Matt Riedemann (mriedem) wrote :
Changed in pbr:
status: New → In Progress
assignee: nobody → Monty Taylor (mordred)
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/200500
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=4442979e71bb09ff9b71604c0dddd37c2bede04d
Submitter: Jenkins
Branch: master

commit 4442979e71bb09ff9b71604c0dddd37c2bede04d
Author: ghanshyam <email address hidden>
Date: Fri Jul 10 21:26:41 2015 +0900

    Fix for mock-1.1.0

    This includes 2 classes of fixes (and 1 skip) for mock.

    The first is the change in allowed values for assert_has_calls -
    https://github.com/testing-cabal/mock/issues/263

    The second is a yet unsolved bug around the use of autospec
    https://github.com/testing-cabal/mock/issues/264

    The skip is because something has changed with mock.open that is
    causing the vhduils test to fail. We don't know why, but it's one test
    to skip.

    This also includes a brute force fix for tox -e docs, because pip is
    no longer respecting the sphinx pin in test requirements. This has to
    be landed with the other changes because they won't work without it.

    Change-Id: Id835d080a1ada52cbd3f24dad9bab5eeb2f29a54
    Partial-Bug: 1473401

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/200865

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (stable/kilo)

Change abandoned by Joshua Hesketh (<email address hidden>) on branch: stable/kilo
Review: https://review.openstack.org/200865

Changed in pbr:
status: In Progress → Fix Committed
Changed in nova:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to nova (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/202113

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/204222

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/204222
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=3f9927e399c683efe099778b8fecc1f2ac5447fd
Submitter: Jenkins
Branch: master

commit 3f9927e399c683efe099778b8fecc1f2ac5447fd
Author: Robert Collins <email address hidden>
Date: Wed Jul 22 06:59:30 2015 +1200

    Fixup uses of mock in hyperv tests

    I ended poking around a bit after mock 1.1.4.

    The current skip is fixable by using a stateful side effect - the only
    reason the test ever worked before is that mock 1.0.1 returned the
    same data from every read call, which was explicitly fixed in Python
    3.4.

    However one of the other 'fixes' was buggy: it works by making the
    strings match up but the code under test can be broken by not doing
    the second open/read and it will still pass : thus the test is invalid
    and should be skipped to avoid incorrect coverage stats.

    Change-Id: Idec1b6b24e6d9d4a7567ae1f7753bffb9cb8bd5b
    Closes-Bug: #1473401

Thierry Carrez (ttx)
Changed in nova:
milestone: none → liberty-2
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to nova (master)

Reviewed: https://review.openstack.org/202113
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1d5b6964d2807c2b7689a5f99a9bd64a311ef068
Submitter: Jenkins
Branch: master

commit 1d5b6964d2807c2b7689a5f99a9bd64a311ef068
Author: Matt Riedemann <email address hidden>
Date: Wed Jul 15 06:41:21 2015 -0700

    Undo tox -e docs pip install sphinx workaround

    Now that we require at least pbr 1.3 and that has
    commit 61a3a1ecdf99c680e509742fdc6c441b499af130 in it,
    let's remove the workaround.

    Change-Id: I4074b05a823d32f5db0051062527b0db4d379b62
    Related-Bug: #1473401

Changed in pbr:
milestone: none → 1.4.0
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: liberty-2 → 12.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.