There is a method which has not been used.

Bug #1473338 reported by Kenji Yasui
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Low
Kenji Yasui

Bug Description

Method "fake_get_target" has not been used since "Change-Id: I43190d1dac33748fe55fa00f260f32ab209be656".

commit 9651f547147188645942466602c92cce06666483
Author: John Griffith <email address hidden>
Date: Tue Nov 18 00:46:54 2014 +0000

    Transition LVM Driver to use Target Objects

    This patch refactors the LVM Driver to take a
    seperate Target object instead of mixing the
    control and data path implementations inside the
    driver itself.

    It removes the volume/iscsi.py and brick/iscsis/*
    files which were duplicating code and actually
    very messy in terms of where calls were actually
    being implemented.

    Change-Id: I43190d1dac33748fe55fa00f260f32ab209be656

...
- def fake_get_target(obj, iqn):
- return 1

$ grep fake_get_target * -r
cinder/tests/unit/targets/test_scst_driver.py: def _fake_get_target_and_lun(*args, **kwargs):
cinder/tests/unit/targets/test_scst_driver.py: def _fake_get_target_chap_auth(*args, **kwargs):
cinder/tests/unit/targets/test_scst_driver.py: side_effect=_fake_get_target_and_lun),\
cinder/tests/unit/targets/test_scst_driver.py: side_effect=_fake_get_target_chap_auth),\
cinder/tests/unit/targets/test_scst_driver.py: def _fake_get_target_and_lun(*args, **kwargs):
cinder/tests/unit/targets/test_scst_driver.py: def _fake_get_target_chap_auth(*args, **kwargs):
cinder/tests/unit/targets/test_scst_driver.py: side_effect=_fake_get_target_chap_auth),\
cinder/tests/unit/targets/test_scst_driver.py: side_effect=_fake_get_target_and_lun):
cinder/tests/unit/targets/test_scst_driver.py: 0, 1, self.fake_volumes_dir, _fake_get_target_chap_auth())
cinder/tests/unit/targets/test_scst_driver.py: def _fake_get_target_and_lun(*args, **kwargs):
cinder/tests/unit/targets/test_scst_driver.py: def _fake_get_target_chap_auth(*args, **kwargs):
cinder/tests/unit/targets/test_scst_driver.py: side_effect=_fake_get_target_chap_auth),\
cinder/tests/unit/targets/test_scst_driver.py: side_effect=_fake_get_target_and_lun):

Tags: tests
Kenji Yasui (k-yasui)
Changed in cinder:
assignee: nobody → Kenji Yasui (k-yasui)
Changed in cinder:
status: New → In Progress
Revision history for this message
Eric Harney (eharney) wrote :

This kind of issue can just be submitted as a patch without a bug.

tags: added: tests
Eric Harney (eharney)
Changed in cinder:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/200378
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=5582b0a55d34727e83329318f441c9f77618cac4
Submitter: Jenkins
Branch: master

commit 5582b0a55d34727e83329318f441c9f77618cac4
Author: Kenji Yasui <email address hidden>
Date: Fri Jul 10 05:02:23 2015 +0000

    Cleanup unused method fake_get_target

    This method has not been used since the change
    I43190d1dac33748fe55fa00f260f32ab209be656
    which removes the callers of fake_get_target()

    Closes-Bug: #1473338
    Change-Id: Ib94d9d3a5d3fd99885ab18cd2efc0730720e8c3f

Changed in cinder:
status: In Progress → Fix Committed
Changed in cinder:
milestone: none → liberty-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: liberty-2 → 7.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.