OpenStack Heat

unavailable resources are still accessible via resource-type-show and successfully validate via template-vaildate

Bug #1473025 reported by Pavlo Shchelokovskyy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
Kanagaraj Manickam
OpenStack Heat 5.0.0 "liberty"

Bug Description

Since https://github.com/openstack/heat/commit/6c50858954830919f983d3303addc7f5d59b23bf we hide unavailable resources from resource-type-list, but they are still accessible via resource-type-show, which IMO should be fixed.

Also, template containing unavailable resources still passes template-validate, which should be fixed too.

Created this bug so we do not forget make these changes.

Sergey Kraynev (skraynev)
Changed in heat:
importance: Undecided → Medium
status: New → Confirmed
milestone: none → liberty-2
Pavlo Shchelokovskyy (pshchelo)
Changed in heat:
assignee: nobody → Kanagaraj Manickam (kanagaraj-manickam)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/201047

Changed in heat:
status: Confirmed → In Progress
Steve Baker (steve-stevebaker)
Changed in heat:
milestone: liberty-2 → liberty-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/201047
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=875e86bf4f436b413c7849a3fb3941f587fdb898
Submitter: Jenkins
Branch: master

commit 875e86bf4f436b413c7849a3fb3941f587fdb898
Author: Kanagaraj Manickam <email address hidden>
Date: Mon Jul 13 10:32:57 2015 +0530

    Resource-type-show does not report unavailable resource type

    When service not available in the service catalog, resource-type-show
    command is updated to report the error instead of showing the resource
    schema.

    Change-Id: I01aaadf86bf86f2a01bfd3fd28541522ef5a99cf
    Partial-Bug: #1473025

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/219237

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/219237
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=10e55e1945da80da2743e1c445524d161d268ad2
Submitter: Jenkins
Branch: master

commit 10e55e1945da80da2743e1c445524d161d268ad2
Author: Kanagaraj Manickam <email address hidden>
Date: Tue Sep 1 16:44:47 2015 +0530

    Engine method validate_template fails for unavailable resource type

    When validate_template() method is called with unavailable resource type,
    it will fails the template validation.

    Change-Id: Id141b7e63d7a58fade8a29d0dd5c6a1f9c847f5e
    Closes-Bug: #1473025

Changed in heat:
status: In Progress → Fix Committed
Doug Hellmann (doug-hellmann)
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: liberty-3 → 5.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.