Fail to boot with snapshot image in vmware driver

[Man Li Qi]

branch: master/kilo

When using nova VMwareVCDriver, nova boot failed with instance snapshot image.

This error is found from tempest failure: tempest.api.compute.servers.test_servers_negative.ServersNegativeTestJSON.test_shelve_shelved_server

Steps to reproduce the failure(command line):
1. Boot an instance using a vmdk image, for example, the instance is named with test1
2. Take a snapshot of the instance:
nova image_create test1 test1_snapshot
3. Boot an instance using the snapshot image, with same disk size flavor in step 1

Expected result: Instance should boot up successfully

Actual result: Instance boots up with ERROR and following error is found in compute.log:
VMwareDriverException: A specified parameter was not correct.
capacity

Full log is available here: http://paste.openstack.org/show/358046/

[Gary Kotton (garyk)]

The solution for https://review.openstack.org/#/c/168013/ addresses this issue

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/168013
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=2f15d304f01a94a788db4175de3905bdd3a3cc62
Submitter: Jenkins
Branch: master

commit 2f15d304f01a94a788db4175de3905bdd3a3cc62
Author: Radoslav Gerganov <email address hidden>
Date: Thu Mar 26 16:22:30 2015 +0200

    VMware: Use virtual disk size instead of image size

    The image size is different from the virtual disk size when the image is
    sparse. For sparse images we get the size of the virtual disk by quering
    the -flat file after converting the disk to preallocated.

    Co-Authored-By: Qin Zhao <email address hidden>

    Change-Id: I18628fe3a180f722936c680c6be30d5ed4d50bd9
    Closes-Bug: #1240373
    Closes-Bug: #1472955

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/252010

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/258020

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/168024
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=bfc5edc405138e3412ae1af01abbf098c319c77c
Submitter: Jenkins
Branch: master

commit bfc5edc405138e3412ae1af01abbf098c319c77c
Author: Radoslav Gerganov <email address hidden>
Date: Thu Mar 26 16:54:05 2015 +0200

    VMware: Handle image size correctly for OVA and streamOptimized images

    The image size is different from the virtual disk size when the image is
    streamOptimized or OVA. In this case we need to use the size of the
    virtual disk which belongs to the temporary VM created by ImportVApp.
    This works for both vSAN and VMFS datastores.

    Related-Bug: #1240373
    Related-Bug: #1472955

    Change-Id: Ie7df9a78632ff01453b07ee9fed3dffdd8b4a0c7

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/liberty
Review: https://review.openstack.org/277990

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/277990
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=2c6c67422e0e9dac5e4bd0b61085d3ca1b32e789
Submitter: Jenkins
Branch: stable/liberty

commit 2c6c67422e0e9dac5e4bd0b61085d3ca1b32e789
Author: Radoslav Gerganov <email address hidden>
Date: Thu Mar 26 16:54:05 2015 +0200

    VMware: Handle image size correctly for OVA and streamOptimized images

    The image size is different from the virtual disk size when the image is
    streamOptimized or OVA. In this case we need to use the size of the
    virtual disk which belongs to the temporary VM created by ImportVApp.
    This works for both vSAN and VMFS datastores.

    (cherry picked from commit bfc5edc405138e3412ae1af01abbf098c319c77c)

    Related-Bug: #1240373
    Related-Bug: #1472955
    Change-Id: Ie7df9a78632ff01453b07ee9fed3dffdd8b4a0c7

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/252010
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=8a9f711c082e564fb5ac2f983a4616652f5b4d3d
Submitter: Jenkins
Branch: stable/kilo

commit 8a9f711c082e564fb5ac2f983a4616652f5b4d3d
Author: Radoslav Gerganov <email address hidden>
Date: Thu Mar 26 16:22:30 2015 +0200

    VMware: Use virtual disk size instead of image size

    The image size is different from the virtual disk size when the image is
    sparse. For sparse images we get the size of the virtual disk by quering
    the -flat file after converting the disk to preallocated.

    Co-Authored-By: Qin Zhao <email address hidden>

    Change-Id: I18628fe3a180f722936c680c6be30d5ed4d50bd9
    Closes-Bug: #1240373
    Closes-Bug: #1472955
    (cherry picked from commit 2f15d304f01a94a788db4175de3905bdd3a3cc62)

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/nova 2015.1.4 release.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Michael Still (<email address hidden>) on branch: master
Review: https://review.openstack.org/258020
Reason: This code hasn't been updated in a long time, and is in merge conflict. I am going to abandon this review, but feel free to restore it if you're still working on this.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 2015.1.4 release.