Web staff client: items out page does not display value of certain columns

[Galen Charlton]

In the web staff client's display of a patron's current loans, the values of several circulation fields (e.g., grace period) are not displayed even when the user adds the column to the grid.

This stems from a glitch in how wildcard egGridField paths are parsed. Consider these two lines from t_items_out.tt2:

  <eg-grid-field path="*" hidden></eg-grid-field>
  <eg-grid-field path="target_copy.*" hidden></eg-grid-field>

The code that expands the path to pull in the relevant IDL fields handles the latter form correctly, but prepends a superfluous "." to each field name when expanding the former.

Evergreen master

[Galen Charlton (gmc)]

Two patches are available at the tip of user/gmcharlt/lp1472787_fix_eg_grid_field_path_expansion in the working/Evergreen repository:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1472787_fix_eg_grid_field_path_expansion

One patch fixes the bug, the other adds unit and regression tests.

    To test:

    [1] In the web staff client, bring up the list of a patron's
        current loans. Add the grace period column to the grid,
        but note that the loans' grace period values are not
        actually displayed.
    [2] Apply the patch.
    [3] Refresh the browser and repeat step 1. This time, the
        grace period values are displayed.

[Mike Rylander (mrylander)]

I've signed off here, and the changes are already incorporated into the sprint 2 webstaff collab branch.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/miker/lp1472787_fix_eg_grid_field_path_expansion

[Jason Stephenson (jstephenson)]

Sorry that I missed your signoff, Mike.

I did give everyone who contributed to the branch credit on the config.upgrade_log line in 002.schema.config.sql.

Thanks everyone!