toggling maximized library swaps focus between tree view and tracks table

[Raf Van De Meirssche]

When I maximize the library, for me that is because I will be scrolling up and down the list.
However, focus is moved to the search box and I have to move focus back to the track list first.
Shouldn't focus be set to the track list immediately?

Strangely ...
When focus is on the library sidebar, it seems to generally go to the track list correctly.
When focus is on the tracklist, it always skips to the searchbox.

Please also note that, for sake of conformity, I would keep the same logic also when restoring.

Build 1.12-r5481
Windows 7 Home premium 64-bit

[Windows 7 Professional 32-bit not verified]
[Ubuntu 14.10 not verified] --- CORRECTION: Ubuntu 14.04

[Ferran Pujol (ferranpujol)]

This is not exactly a duplicate. We fixed Bug #1462061 and now when the library is maximized the focus switches to the library tree instead of the search box. Anyway, the user can't keep navigating through the tracks with the keyboard unless he/she hits tab once.

[Owen Williams (ywwg)]

It sounds like the previous fix wasn't really a fix. If we fix this new problem, we should probably roll back that other change to keep tab selection consistent with previous versions.

[Takeshi Soejima (sohet)]

At this moment (github master), the focus still moves unintentionally between main library view and library sidebar when toggling maximize_library. Tango skin shows it clearly.

[ronso0 (ronso0)]

yes, this bug is still valid.
right now, only in Shade the focus is static as Sahde loads a single library.
In all other skins we load the library as a Singleton:
1) library normal: [decks, effects, ...] + library Singleton #1
2) library maximized: library Singleton #2.

IDK why it was like this.. I adapted to it with Tango and LateNight redesign.
I'll try to simplify this in my current skin PRs
https://github.com/mixxxdj/mixxx/pull/1799
https://github.com/mixxxdj/mixxx/pull/1800
https://github.com/mixxxdj/mixxx/pull/1801

[ronso0 (ronso0)]

now I recall why we need the library Singleton (learned it the hard way, again):
it lets the library grow/shrink correctly when the stacked waveforms splitter is resized.
I don't see a way to fix this from the skin side.
sorry for the noise.

[ronso0 (ronso0)]

however, the scroll position is kept both in tree and tracks table.

[ronso0 (ronso0)]

In LateNight the focus stays on library (but jumps between tree & table).
There we use a WidgetStack to toggle maximized libary.

In Tango & Deere the focus is removed from the libary.
There we use WidgetGroups with a "visible" connection.

Shade doesn't have that problem at all (no splitter, no Singletons)

Can this be fixed for 2.2 in C++?
Or should I modify Tango & Deere so that they also at least keep any focus on the library, instead of removing the focus completely and leaving the user in a somewhat vague situation that can be clarified by trial-and-error only (press Tab)?

[ronso0 (ronso0)]

related: lp:1673196

[ronso0 (ronso0)]

with 2.2 I noticed something with Deere skin:
* focus the tracks table
* toggle skin settings menu (open or close doesn't matter)
> focus jumps to tree

* focus tree
* toggle skin settings menu (open or close doesn't matter)
> tree is unfocused for an instant

[ronso0 (ronso0)]

also fixed by https://github.com/mixxxdj/mixxx/pull/2289

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/8140