no gateway in default network configuration of new nodegroup

[Marcin Iwinski]

Network yaml downloaded for environment with nodegroups is missing gateways for all networks associated with non-default nodegroups. Missing gateway is not detected prior to deployment causing the deployment to fail cause static routes from new networks are not set on hosts deployed in non-default nodegroups.

VERSION:
  feature_groups:
    - mirantis
    - experimental
  production: "docker"
  release: "6.1"
  openstack_version: "2014.2.2-6.1"
  api: "1.0"
  build_number: "521"
  build_id: "2015-06-08_06-13-27"
  nailgun_sha: "4340d55c19029394cd5610b0e0f56d6cb8cb661b"
  python-fuelclient_sha: "4fc55db0265bbf39c369df398b9dc7d6469ba13b"
  astute_sha: "7766818f079881e2dbeedb34e1f67e517ed7d479"
  fuel-library_sha: "f43c2ae1af3b493ee0e7810eab7bb7b50c986c7d"
  fuel-ostf_sha: "7c938648a246e0311d05e2372ff43ef1eb2e2761"
  fuelmain_sha: "bcc909ffc5dd5156ba54cae348b6a07c1b607b24"

Steps to reproduce:
1) create new environment with neutron+gre
fuel env create --name nodegroup-test --release 2 --nst gre

2) create new node group in this environment
fuel --env 1 nodegroup --create --name "tor1"

3) download network yaml
fuel --env 1 network --download

Expected behavior:
Together with default IP ranges there is also a default IP used as a gateway for all networks with group_id different than 1.
If the gateway is not set it should be detected either during the upload of the file or before the deployment starts using "deploy changes".

Current behaviour:
gateway is set to null, and this value is not validated prior to deployment so if this parameter is missed new hosts deployed in separate network segments have no connectivity to internal networks (unless allowed via default gateway).

[Vladimir Sharshov (vsharshov)]

Looks like problem located in Nailgun. Assigned to Fuel Python Team.

[Andrew Woodward (xarses)]

When two networks are present and mapped to the same name, or network-role they should be checked for a gateway on upload. This probably should be added to the validation when updating the networks on the cluster.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/210034

[OpenStack Infra (hudson-openstack)]

Change abandoned by Alexander Kuleshov (<email address hidden>) on branch: master
Review: https://review.openstack.org/210034
Reason: Addressed by https://review.openstack.org/#/c/211126/

[OpenStack Infra (hudson-openstack)]

Change abandoned by Alexander Kuleshov (<email address hidden>) on branch: stable/6.1
Review: https://review.openstack.org/209452
Reason: Addressed by https://review.openstack.org/#/c/213045/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/6.1
Review: https://review.openstack.org/213064

[Dmitry Pyzhov (dpyzhov)]

Here is master review: https://review.openstack.org/#/c/210033/

[Andrew Woodward (xarses)]

Uploading of a network without a gateway should be allowed, In some cases a user may actually want this to create some form of isloation. It should result in a warning though "Gateway is not set, routes will not be configured to this {network} for {nodegroup}"

[Aleksandr Didenko (adidenko)]

Andrew, isolation of public/management/storage network would cause a deployment failure. If user wants isolation for some new custom network, then he can specify fake IP (non-existing router) or make isolation on physical layer :)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/210033
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=b6606ea1d85a1f2937047d4397e0f35d44bfa889
Submitter: Jenkins
Branch: master

commit b6606ea1d85a1f2937047d4397e0f35d44bfa889
Author: Alexander Kuleshov <email address hidden>
Date: Wed Aug 12 17:02:16 2015 +0300

    Check gateways if non-default node groups are used

    Add neutron_check_gateways to NetworkCheck class which checks that
    valid gateways are specified for all networks if non-default node
    groups are used.

    Change-Id: I433bc322bbfa2e121fba77ea9802d4a5d3a218ad
    Closes-Bug: #1472662

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/7.0
Review: https://review.openstack.org/239474

[OpenStack Infra (hudson-openstack)]

Change abandoned by Alexander Kuleshov (<email address hidden>) on branch: stable/7.0
Review: https://review.openstack.org/239474
Reason: Wrong Change-Id

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/7.0
Review: https://review.openstack.org/239501

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/239501
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=e16bbf4f52aa1ec1fcd2ecdb4cfa4971e8353d02
Submitter: Jenkins
Branch: stable/7.0

commit e16bbf4f52aa1ec1fcd2ecdb4cfa4971e8353d02
Author: Alexander Kuleshov <email address hidden>
Date: Wed Aug 12 17:02:16 2015 +0300

    Check gateways if non-default node groups are used

    Add neutron_check_gateways to NetworkCheck class which checks that
    valid gateways are specified for all networks if non-default node
    groups are used.

    Change-Id: I433bc322bbfa2e121fba77ea9802d4a5d3a218ad
    Closes-Bug: #1472662

[Andrey Sledzinskiy (asledzinskiy)]

verified on 7.0-301 with MU

[Nastya Urlapova (aurlapova)]

Moved to Fix Released according to a comment above.

[Vladimir (vushakov)]

Verified on Fuel 8.0

VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  openstack_version: "2015.1.0-8.0"
  api: "1.0"
  build_number: "239"
  build_id: "239"
  fuel-nailgun_sha: "fb41bdfa439c62c611d70be10cca2347ca59e0ef"
  python-fuelclient_sha: "91474bd8c526f4f536ab13368feb4a5c1b84d185"
  fuel-agent_sha: "e14fcec6ac90ccc39eb512880170281d032bae4b"
  fuel-nailgun-agent_sha: "a33a58d378c117c0f509b0e7badc6f0910364154"
  astute_sha: "b60624ee2c5f1d6d805619b6c27965a973508da1"
  fuel-library_sha: "715085df553204555252a0b905ec5d8a3e5aad98"
  fuel-ostf_sha: "a98973482f839554d90cc1c071d625a01e018cfe"
  fuel-createmirror_sha: "3cb98030d4a12992ea1cda1f464f035980569d2f"
  fuelmenu_sha: "fcb15df4fd1a790b17dd78cf675c11c279040941"
  shotgun_sha: "25a0cc461a9fa4f7684f04cef0ff4ad9aa99a64d"
  network-checker_sha: "a3534f8885246afb15609c54f91d3b23d599a5b1"
  fuel-upgrade_sha: "1e894e26d4e1423a9b0d66abd6a79505f4175ff6"
  fuelmain_sha: "7ccc35fd66431ed8b6516748dcaf99b76a8c1386"

[OpenStack Infra (hudson-openstack)]

Change abandoned by Tony Breeds (<email address hidden>) on branch: stable/6.1
Review: https://review.openstack.org/213064
Reason: This branch (stable/6.1) is at End Of Life