Some env variable usage issues in scripts responsible for creating venv

Bug #1472509 reported by Ghanshyam Mann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
oslo-incubator
Fix Released
Undecided
Ghanshyam Mann

Bug Description

There are couple of issues in the scripts responsible for creating virtual environment.

1. install_venv.py
 - Tool path env variable is used as lower case in install_venv.py ('tools_path') and uppercase in other scripts with_venv.sh and run_tests_common.sh ('TOOLS_PATH')

we should use upper case ('TOOLS_PATH') in install_venv.py also.

2. with_venv.sh
- If some of env variable is being set not all then, it would not work as expected. for example if 'TOOLS_PATH' is only set then VENV path would not be proper.
 export TOOLS_PATH='/opt/stack/oslo-incubator/'
then venv gets created in '/opt/stack/oslo-incubator/.venv' but path constructed in with_venv.sh script will be '/opt/stack/oslo-incubator/../.venv' and it fails.

3. run_tests_common.sh
- VENV_NAME is being used to populate the VENV_DIR value but when venv name is being passed as argument in this script (--virtual-env-name) then VENV_NAME is not set and it fails with_venv.sh script which use VENV_NAME.

we should remove VENV_NAME and make use of VENV_DIR to fix this issue and to avoid confusion of having two env variable options.

Changed in oslo-incubator:
assignee: nobody → Ghanshyam Mann (ghanshyammann)
description: updated
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote :
Changed in oslo-incubator:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.