Arista ML2 VLAN driver should ignore non-VLAN network types

Bug #1472458 reported by Sukhdev Kapur
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Sukhdev Kapur
Juno
Fix Released
Low
Sukhdev Kapur
Kilo
Fix Released
Low
Sukhdev Kapur

Bug Description

Arista ML2 VLAN driver should process only VLAN based networks. Any other network type (e.g. vxlan) should be ignored.

summary: - Arista ML2 VLAN driver should ignore any other network types
+ Arista ML2 VLAN driver should ignore non-VLAN network types
Changed in neutron:
assignee: nobody → Sukhdev Kapur (sukhdev-8)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/199380
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=581438a5b6dde5f161e1c129314a7bcaaae8da20
Submitter: Jenkins
Branch: master

commit 581438a5b6dde5f161e1c129314a7bcaaae8da20
Author: Sukhdev Kapur <email address hidden>
Date: Tue Jul 7 19:39:15 2015 -0700

    Arista ML2 driver should ignore non-vlan networks

    Arista ML2 Mech driver for VLANs presently does
    not filter out non-vlan type networks (e.g vxlan).
    This fix will simply ignore the request if a
    non-vlan based network request is seen.

    Change-Id: I99ec5c5772a9f1f63cf871a98be50bdd2ba5db62
    Closes-Bug: 1472458

Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/200789

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (feature/pecan)

Fix proposed to branch: feature/pecan
Review: https://review.openstack.org/201131

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/juno)

Reviewed: https://review.openstack.org/200789
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=17c6bc5df2be43a658598aae0b23b406caeacf35
Submitter: Jenkins
Branch: stable/juno

commit 17c6bc5df2be43a658598aae0b23b406caeacf35
Author: Sukhdev Kapur <email address hidden>
Date: Tue Jul 7 19:39:15 2015 -0700

    Arista ML2 driver should ignore non-vlan networks

    Arista ML2 Mech driver for VLANs presently does
    not filter out non-vlan type networks (e.g vxlan).
    This fix will simply ignore the request if a
    non-vlan based network request is seen.

    This patch is a juno port for https://review.openstack.org/#/c/199380/8
    The cherry-picking had to be done manually because of the decomposition
    of the repository

    Conflicts:
     neutron/plugins/ml2/drivers/arista/mechanism_arista.py
     neutron/tests/unit/plugins/ml2/drivers/arista/test_mechanism_arista.py

    Change-Id: I99ec5c5772a9f1f63cf871a98be50bdd2ba5db62
    Closes-Bug: 1472458

tags: added: in-stable-juno
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/201260

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/kilo)

Reviewed: https://review.openstack.org/201260
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=478f4e82b12158496dcd75966a46b0f50fff79b7
Submitter: Jenkins
Branch: stable/kilo

commit 478f4e82b12158496dcd75966a46b0f50fff79b7
Author: Sukhdev Kapur <email address hidden>
Date: Tue Jul 7 19:39:15 2015 -0700

    Arista ML2 driver should ignore non-vlan networks

    Arista ML2 Mech driver for VLANs presently does
    not filter out non-vlan type networks (e.g vxlan).
    This fix will simply ignore the request if a
    non-vlan based network request is seen.

    Change-Id: I99ec5c5772a9f1f63cf871a98be50bdd2ba5db62
    Closes-Bug: 1472458
    (cherry picked from commit 581438a5b6dde5f161e1c129314a7bcaaae8da20)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (feature/pecan)
Download full text (8.8 KiB)

Reviewed: https://review.openstack.org/201131
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=3a9975cbc30d9253b96cec9e079b411add184ec1
Submitter: Jenkins
Branch: feature/pecan

commit c27e66cc7c3427dfbc1e390693c6b0a3e656c783
Author: YAMAMOTO Takashi <email address hidden>
Date: Fri Jun 19 16:28:23 2015 +0900

    Reject router-interface-add with a port which doesn't have any addresses

    Fix a regression in commit I7d4e8194815e626f1cfa267f77a3f2475fdfa3d1 .

    Closes-Bug: #1466750
    Related-Bug: #1439824
    Change-Id: Ic0c4c0adbffe14b1f08d4b2dee91e1dff41cc770

commit 83cac810f00933d8b22f17cdcc20094e1d27a018
Author: OpenStack Proposal Bot <email address hidden>
Date: Sat Jul 11 06:09:29 2015 +0000

    Imported Translations from Transifex

    For more information about this automatic import see:
    https://wiki.openstack.org/wiki/Translations/Infrastructure

    Change-Id: I33a9e5a28666a295dd24f6c482b9805b33d0ca69

commit 5b066a237ec0918d882ef2455aef4f2f9cb0606c
Author: Ihar Hrachyshka <email address hidden>
Date: Fri Jul 10 14:07:09 2015 +0200

    Enforce specific order for firewall.(un)filtered_ports and devices

    Lots of tests in the file rely on specific order of devices and ports
    with which they are iterated thru inside firewall implementation. This
    is needed to match a regexp against iptables output generated by the
    firewall driver.

    In production code, those .(un)filtered_ports dictionaries are
    unordered, and it would be not wise to enforce the order for them just
    for the sake of those unit tests.

    Instead, we 'patch' the agent firewall with ordered versions of dict for
    those attributes.

    Also enforce specific order for device_info dictionaries we pass into
    firewall.

    The failure was easily reproducible with PYTHONHASHSEED=111, and after
    the fix, it's gone.

    While at it, stop making assumptions about stable order of dict.values()
    between multiple dictionaries with the same keys. It may actually work
    for now, but it seems fragile. Overall simplified regex construction
    code a bit, f.e. killing some dead or redundant code.

    Closes-Bug: #1473413
    Change-Id: I170087426bc961592b4c4923c64a5fea30d51c21

commit dfbe804994a576994768c95720b4f0ba53e313d7
Author: Dan Prince <email address hidden>
Date: Thu Jul 9 15:31:13 2015 -0400

    get_vif_ports: ignore non-Interface ports

    This patch updates get_vif_ports so that it skips
    ports which aren't in the 'Interfaces' table.

    This fixes an issue where neutron-ovs-cleanup would
    fail if any sort of OVS bond was on the bridge getting
    cleaned up. This is because bonds don't have the same
    attributes as ports, and thus fail subsequent ovs-vsctl
    queries.

    Change-Id: Ic9d30e5916122ce23c5dc8631fbb71115ae8a960
    Closes-bug: #1473179

commit 1025baec55235bf4981872390f1bb65f4e3ae7e6
Author: Wei Wang <email address hidden>
Date: Thu Sep 25 17:49:59 2014 +0800

    Fix duplicate entry catch for allowed address pairs

    If None is submitted as a MAC address in an allowed_address_pair,
 ...

Read more...

tags: added: in-feature-pecan
Kyle Mestery (mestery)
Changed in neutron:
importance: Undecided → Low
milestone: none → liberty-2
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: liberty-2 → 7.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.