Fuel for OpenStack

Gerrit permissions to vote Workflow+1 on stable/6.1 are not exclusive to fuel-stable-core

Bug #1472424 reported by Dmitry Borodaenko
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
Critical
Igor Belikov
Fuel for OpenStack 6.1-updates

Bug Description

The access control change in https://review.openstack.org/196130 did not prevent the following commit from being merged into stable/6.1 branch of fuel-library: https://review.openstack.org/198969.

I believe the problem is that Workflow+1 is granted by the "refs/heads/*" that matches "refs/heads/stable/6.1", and separate permissions for the latter do not have exclusive flag set.

Tags: devops
Revision history for this message
Dmitry Borodaenko (angdraug) wrote :

https://gerrit-review.googlesource.com/Documentation/access-control.html#_project_access_control_lists

"It is possible to configure Gerrit to grant an exclusive ref level access control so that only users of a specific group can perform an operation on a project/reference pair. This is done by ticking the exclusive flag when setting the permission for the refs/heads/qa branch."

Igor Belikov (ibelikov)
Changed in fuel:
assignee: Fuel DevOps (fuel-devops) → Igor Belikov (ibelikov)
status: Confirmed → In Progress
Revision history for this message
Igor Belikov (ibelikov) wrote :

https://review.openstack.org/#/c/199448/ is merged

Changed in fuel:
status: In Progress → Fix Committed
Igor Belikov (ibelikov)
Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.