AIO inventory has swift_proxy_vars and swift_vars for each container

Bug #1472261 reported by Matt Thompson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack-Ansible
Fix Released
Low
git-harry
Kilo
Fix Released
Low
git-harry
Trunk
Fix Released
Low
git-harry

Bug Description

The inventory on an AIO has swift_proxy_vars and swift_vars keys for each container/host, these should probably be limited to the swift hosts only.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to os-ansible-deployment (master)

Fix proposed to branch: master
Review: https://review.openstack.org/201644

Changed in openstack-ansible:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on os-ansible-deployment (master)

Change abandoned by Matt Thompson (<email address hidden>) on branch: master
Review: https://review.openstack.org/199094
Reason: Abandoned in favour of https://review.openstack.org/#/c/201644/.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-ansible-deployment (master)

Reviewed: https://review.openstack.org/201644
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=1ef256a3082759213e41ffb136596001e88de4d2
Submitter: Jenkins
Branch: master

commit 1ef256a3082759213e41ffb136596001e88de4d2
Author: git-harry <email address hidden>
Date: Tue Jul 14 16:47:17 2015 +0100

    Target AIO swift vars at specific containers

    The variables defined in etc/openstack_deploy/conf.d/swift.yml are
    added as hostvars by the dynamic inventory script. Currently the vars
    are being added to hosts that do not require them.

    There is a variable called limit_container_types that is used by the
    dynamic inventory to filter the hosts to which variables are assigned.
    This script makes use of that variable so that only swift hosts have
    these variables set.

    The dynamic inventory script checks to see if the limit_container_types
    string is in the container name as the method of filtering. This means
    that the AIO host, aio1, does not get swift_vars assigned to it. This
    commit alters the filter so that the component is checked instead of the
    container name.

    Change-Id: I945594a55ce058d822b941d08eb0ad9c5614db15
    Closes-bug: #1472261

Changed in openstack-ansible:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-ansible-deployment (kilo)

Reviewed: https://review.openstack.org/204949
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=b581c8bdc55b000f1ca241c041181a78045bbc7c
Submitter: Jenkins
Branch: kilo

commit b581c8bdc55b000f1ca241c041181a78045bbc7c
Author: git-harry <email address hidden>
Date: Tue Jul 14 16:47:17 2015 +0100

    Target AIO swift vars at specific containers

    The variables defined in etc/openstack_deploy/conf.d/swift.yml are
    added as hostvars by the dynamic inventory script. Currently the vars
    are being added to hosts that do not require them.

    There is a variable called limit_container_types that is used by the
    dynamic inventory to filter the hosts to which variables are assigned.
    This script makes use of that variable so that only swift hosts have
    these variables set.

    The dynamic inventory script checks to see if the limit_container_types
    string is in the container name as the method of filtering. This means
    that the AIO host, aio1, does not get swift_vars assigned to it. This
    commit alters the filter so that the component is checked instead of the
    container name.

    Change-Id: I945594a55ce058d822b941d08eb0ad9c5614db15
    Closes-bug: #1472261
    (cherry picked from commit 1ef256a3082759213e41ffb136596001e88de4d2)

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/openstack-ansible 11.2.14

This issue was fixed in the openstack/openstack-ansible 11.2.14 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.