Include the key.js file in the source tree
Bug #1471329 reported by
Nekhelesh Ramananthan
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu Weather App |
Fix Released
|
Low
|
Victor Thompson |
Bug Description
Is there any reason why we aren't including the key.js file in the source tree? Either way weather app is an open-source app and thereby anyone can grab the key by looking at the installed files of the weather app. It is just an unnecessary step for developers and is incredibly annoying.
Related branches
lp:~vthompson/ubuntu-weather-app/reboot-default-OWM-blank-key
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
- Andrew Hayzen: Approve
-
Diff: 58 lines (+13/-1)3 files modifiedapp/ubuntu-weather-app.qml (+4/-0)
app/ui/settings/DataProviderPage.qml (+8/-1)
debian/changelog (+1/-0)
Changed in ubuntu-weather-app: | |
status: | New → In Progress |
importance: | Undecided → Low |
assignee: | nobody → Victor Thompson (vthompson) |
Changed in ubuntu-weather-app: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I agree that it's inconvenient, however, API keys for external services are something that should be managed at configuration/build time of the app. Any subsequent fork of the project shouldn't inherit an API key and should file for their own. One option could be to obfuscate the key--however, I assume this isn't acceptable either.