Fuel-library fuel_syntax_check.sh failures
Bug #1471198 reported by
Aleksandr Didenko
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Fuel for OpenStack |
Fix Released
|
Critical
|
Aleksandr Didenko | ||
7.0.x |
Fix Released
|
Critical
|
Aleksandr Didenko |
Bug Description
Our syntax check script sometimes produces false negative results. Most likely it's caused by setting $GEM_HOME script wide, which breaks 'puppet-lint' command (it uses puppet-lint gem from the latest 'bundle' execution, instead of system-wide gem installed with 'puppet-lint' package). We should set $GEH_HOME only for 'bundle' commands in order to not affect other ruby executables.
The other problem is caused with broken 'rake lint' tests for some modules. We can switch style checks for such modules from 'rake lint' to 'puppet-lint'.
Changed in fuel: | |
status: | New → In Progress |
summary: |
- Fuel-library fuel_syntax_check.sh false negative + Fuel-library fuel_syntax_check.sh failures |
description: | updated |
Changed in fuel: | |
milestone: | none → 7.0 |
milestone: | 7.0 → none |
tags: | added: 70-kilo-blocker |
Changed in fuel: | |
status: | In Progress → Fix Committed |
To post a comment you must log in.
Fix proposed https:/ /review. openstack. org/198314