Test that WebContextMenu position property is in the correct coordinate space
Bug #1471181 reported by
Chris Coulson
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Oxide |
Fix Released
|
Medium
|
Olivier Tilloy | ||
1.9 |
Fix Released
|
Medium
|
Olivier Tilloy |
Bug Description
From looking at the code in Chromium that is used to bring up the context menu, it's not clear whether the position is in the source frame's coordinate space, or the WebView one. It's also not clear whether it's in physical or device-independent pixels.
It should be in the WebView coordinate space, and in physical pixels.
Testing this sort-of depends on bug 1399207, which will make it easier to add new test runs with arbitrary configurations (such as a non-unity device scale).
Related branches
lp:~osomon/webbrowser-app/oxide-context-menu
- Ken VanDine: Approve
- Ugo Riboni (community): Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 2579 lines (+1390/-690)34 files modifieddebian/control (+2/-12)
debian/qtdeclarative5-ubuntu-web-plugin-assets.install (+0/-1)
debian/rules (+0/-4)
doc/WebView.qdoc (+44/-5)
src/Ubuntu/Web/CMakeLists.txt (+0/-3)
src/Ubuntu/Web/Selection.qml (+0/-161)
src/Ubuntu/Web/SelectionHandle.qml (+0/-47)
src/Ubuntu/Web/UbuntuWebView02.qml (+60/-156)
src/Ubuntu/Web/selection02.js (+2/-131)
src/app/CMakeLists.txt (+1/-0)
src/app/FileExtensionMapper.js (+11/-7)
src/app/FilePickerDialog.qml (+2/-2)
src/app/WebViewImpl.qml (+20/-9)
src/app/actions/Cut.qml (+23/-0)
src/app/actions/Erase.qml (+23/-0)
src/app/actions/Paste.qml (+23/-0)
src/app/actions/Redo.qml (+23/-0)
src/app/actions/SaveLink.qml (+23/-0)
src/app/actions/SelectAll.qml (+23/-0)
src/app/actions/Undo.qml (+23/-0)
src/app/browserapplication.cpp (+9/-0)
src/app/mime-database.cpp (+33/-0)
src/app/mime-database.h (+39/-0)
src/app/webbrowser/Browser.qml (+103/-26)
src/app/webbrowser/ContextMenuMobile.qml (+168/-0)
src/app/webbrowser/ContextMenuWide.qml (+158/-0)
src/app/webbrowser/assets/stock_link.svg (+164/-0)
src/app/webcontainer/WebViewImplOxide.qml (+42/-5)
tests/autopilot/webbrowser_app/emulators/browser.py (+33/-16)
tests/autopilot/webbrowser_app/tests/http_server.py (+28/-0)
tests/autopilot/webbrowser_app/tests/test_contextmenu.py (+177/-0)
tests/autopilot/webbrowser_app/tests/test_selection.py (+0/-92)
tests/unittests/qml/tst_FileExtensionMapper.qml (+39/-0)
tests/unittests/qml/tst_UbuntuWebView02.qml (+94/-13)
lp:~osomon/oxide/contextmenu-position-physical-pixels
- Chris Coulson: Pending requested
-
Diff: 24 lines (+6/-1)1 file modifiedqt/core/browser/oxide_qt_web_context_menu.cc (+6/-1)
Changed in oxide: | |
importance: | Undecided → Medium |
status: | New → Triaged |
Changed in oxide: | |
status: | In Progress → Fix Released |
milestone: | none → 1.9.1 |
milestone: | 1.9.1 → branch-1.10 |
To post a comment you must log in.
I just did some tests on a touch device, and it appears the position is expressed in device-independent pixels. One needs to multiply the coordinates by document. defaultView. devicePixelRati o to obtain a value in physical pixels.