Resize instance via Heat might fail

[Bruno Bompastor]

Changing the flavor of the instance on a heat template and then issuing a stack-update might fail.

This happens here: https://github.com/openstack/heat/blob/master/heat/engine/clients/os/nova.py#L435

When a server says ACTIVE, than heat does a resize, and by the time check_resize is executed for the first time, server status is still ACTIVE - heat will through error.

The proposed fix is to verify that resize is only allowed for ACTIVE states, and then add ACTIVE as allowed value in check_resize.

I tested this on Juno but since the code has not changed in master the bug is still there.

[Bruno Bompastor (bruno-bompastor)]

Is it possible to backport this to Juno?

[Kairat Kushaev (kkushaev)]

I'll propose it for Juno. Let's see that the other guys say.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/201612

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/201612
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=274f96b8e51ba04d5c1230c0fa3aa8066b24901e
Submitter: Jenkins
Branch: stable/kilo

commit 274f96b8e51ba04d5c1230c0fa3aa8066b24901e
Author: kairat_kushaev <email address hidden>
Date: Mon Jul 6 11:32:16 2015 +0300

    Support time-delays in server.resize

    Resize operation in nova(that we are for flavor update) is
    asynchronous. So the server may be ACTIVE when we are checking
    server-resize operations(not RESIZE as was excepted).
    We need to wait for a while till the server becomes RESIZE.

    The patch add support of this case to Server resource in heat.
    Closes-bug: #1471135

    Conflicts:
     heat/tests/test_instance.py
     heat/tests/test_server.py
    (cherry-picked from commit f46af8a8e2daa52f6485d65da4ad69db6f0a32bd)

    Change-Id: I19914081996104c5f2144a6de795173f26774c21

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/246113

[OpenStack Infra (hudson-openstack)]

Change abandoned by Jeremy Stanley (<email address hidden>) on branch: stable/juno
Review: https://review.openstack.org/246113
Reason: I'm abandoning this change in preparation for deleting the stable/juno branch, which is now at end of life.