RetriesTestCase slow tests

Bug #1470914 reported by Lucas Alvares Gomes
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-ironicclient
Fix Released
Medium
Lucas Alvares Gomes

Bug Description

The tests at ironicclient/tests/unit/test_http.py:RetriesTestCase are spending a bunch of time sleeping.

(venv)[lucasagomes@lucasagomes python-ironicclient]$ testr slowest
Test id Runtime (s)
--------------------------------------------------------------------------------- -----------
ironicclient.tests.unit.test_http.RetriesTestCase.test_session_change_max_retries 12.015
ironicclient.tests.unit.test_http.RetriesTestCase.test_session_max_retries_none 10.013
ironicclient.tests.unit.test_http.RetriesTestCase.test_session_retry_fail 10.010
ironicclient.tests.unit.test_http.RetriesTestCase.test_session_retry 2.003
ironicclient.tests.unit.test_shell.ShellTest.test_password_prompted 0.500
ironicclient.tests.unit.test_shell.ShellTest.test_help 0.109
ironicclient.tests.unit.test_shell.ShellTest.test_auth_param 0.085
ironicclient.tests.unit.test_shell.ShellTest.test_ironic_api_version 0.073
ironicclient.tests.unit.test_shell.ShellTestNoMox.test_node_list 0.052
ironicclient.tests.unit.test_shell.ShellTest.test_debug 0.039

Sleep time should be mocked on tests

Changed in python-ironicclient:
assignee: nobody → Lucas Alvares Gomes (lucasagomes)
importance: Undecided → Medium
Changed in python-ironicclient:
status: New → In Progress
Changed in python-ironicclient:
status: In Progress → Fix Committed
Revision history for this message
Dmitry Tantsur (divius) wrote :

please merge https://review.openstack.org/#/c/196020/ if you're affected by this :)

Revision history for this message
Dmitry Tantsur (divius) wrote :

ah, so you just stepped on my shoes instead, nice..

Revision history for this message
Lucas Alvares Gomes (lucasagomes) wrote :

Oh sorry, I didn't see that. I was working on https://review.openstack.org/#/c/198021/ and noticed the tests were pretty slow so I just submitted a patch fixing the timing.

I see now that #196020 was fixing that problem but it's also doing something else (bumping the default retry value to matches nova default)

Changed in python-ironicclient:
milestone: none → 0.8.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.