LIO broken in Juno

[Gorka Eguileor]

This issue only affect stable/Juno with LIO target helper, and it happens whenever terminate_connection is called (for example on detach).

Received error is: "VolumeBackendAPIException: Bad or unexpected response from the storage volume backend API: Unable to terminate volume connection: 'LioAdm' object has no attribute 'terminate_connection'\n"

The problem is that when patch to fix SolidFire issue with iscsi_helper was merged (this was actually a problem in the iscsi driver) it introduced a terminate_connection method in lvm driver that called lioadm terminate_connection. But this method doesn't exist in Juno.

That method was introduced by a patch [2] that ensured that initiators were deleted on terminate_connection for LIO.

[1]: https://github.com/openstack/cinder/commit/9c0a64f3d7153bc262ce4fa0280a895992a9994f
[2]: https://github.com/openstack/cinder/commit/641a44eb17a8de53e54f09a2dc339129d41c529f

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/197149

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/197149
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=22ad32603ca7fd9a6e8f66f36bb52350a6064558
Submitter: Jenkins
Branch: stable/juno

commit 22ad32603ca7fd9a6e8f66f36bb52350a6064558
Author: Gorka Eguileor <email address hidden>
Date: Tue Jun 30 17:46:06 2015 +0200

    Remove nonexistent LIO terminate_connection call

    Commit 9c0a64f3d7153bc262ce4fa0280a895992a9994f introduced a call to
    LIO's target helper method terminate_connection but such method does not
    exist in Juno.

    This patch removes method terminate_connection from LVMISCSIDriver (the
    one that was calling target's terminate_connection). This way parent
    class ISCSIDriver's terminate_connection will be called as it was before.

    Alternative would be backporting commit
    641a44eb17a8de53e54f09a2dc339129d41c529f.

    Change-Id: I80f0784b7718aff1feea4db19602616f0dfed8c5
    Closes-bug: #1470146