HBSD horcm driver crashes with oslo.concurrency 2.1.0

[Marcus V R Nascimento]

The oslo.concurrency 2.1.0 has replaced locks and replaced with fasteners which means that locking stuff has moved to a generic 3rd party lib. This change crashes the Hitachi HBSD horcm driver which raises the following error when the driver initializes:

2015-06-23 16:28:01.595 ERROR cinder.volume.manager [req-25a449f4-27d4-4890-818f-e1104c20c5d0 None] [driver-VolumeManager] Failed to initialize driver.
2015-06-23 16:28:01.595 15340 ERROR cinder.volume.manager Traceback (most recent call last):
2015-06-23 16:28:01.595 15340 ERROR cinder.volume.manager File "/opt/stack/new/cinder/cinder/volume/manager.py", line 302, in init_host
2015-06-23 16:28:01.595 15340 ERROR cinder.volume.manager self.driver.do_setup(ctxt)
2015-06-23 16:28:01.595 15340 ERROR cinder.volume.manager File "/usr/local/lib/python2.7/dist-packages/osprofiler/profiler.py", line 105, in wrapper
2015-06-23 16:28:01.595 15340 ERROR cinder.volume.manager return f(*args, **kwargs)
2015-06-23 16:28:01.595 15340 ERROR cinder.volume.manager File "/opt/stack/new/cinder/cinder/volume/drivers/hitachi/hbsd_fc.py", line 313, in do_setup
2015-06-23 16:28:01.595 15340 ERROR cinder.volume.manager self.common.command.connect_storage()
2015-06-23 16:28:01.595 15340 ERROR cinder.volume.manager File "/opt/stack/new/cinder/cinder/volume/drivers/hitachi/hbsd_horcm.py", line 1493, in connect_storage
2015-06-23 16:28:01.595 15340 ERROR cinder.volume.manager self.setup_horcmgr(properties['ip'])
2015-06-23 16:28:01.595 15340 ERROR cinder.volume.manager File "/opt/stack/new/cinder/cinder/volume/drivers/hitachi/hbsd_horcm.py", line 250, in setup_horcmgr
2015-06-23 16:28:01.595 15340 ERROR cinder.volume.manager with self.horcmgr_flock:
2015-06-23 16:28:01.595 15340 ERROR cinder.volume.manager File "/opt/stack/new/cinder/cinder/volume/drivers/hitachi/hbsd_basiclib.py", line 201, in __enter__
2015-06-23 16:28:01.595 15340 ERROR cinder.volume.manager if not os.access(self.fname, os.W_OK):
2015-06-23 16:28:01.595 15340 ERROR cinder.volume.manager AttributeError: 'FileLock' object has no attribute 'fname'
2015-06-23 16:28:01.595 15340 ERROR cinder.volume.manager

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/197686
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=1c6a57d722f21cc499912bbc389267151b44c962
Submitter: Jenkins
Branch: master

commit 1c6a57d722f21cc499912bbc389267151b44c962
Author: marcusvrn <email address hidden>
Date: Wed Jul 1 15:03:40 2015 -0300

    Fix HBSD horcm driver with oslo.concurrency 2.1.0

    The oslo.concurrency 2.1.0 has replaced locks and replaced with fasteners which
    means that locking stuff has moved to a generic 3rd party lib. This lib uses
    the variable "path" instead of "fname".

    Closes-bug: #1470112
    Change-Id: I8b844c827c940a01da9cd97d8f69b3a7e42f706c