Trove reports exists event in context of future audit period

[Rohit Jaiswal]

When Trove emits exists notification, it includes an audit period. This should be the most recently completed audit period/ period of usage. This how nova does it - https://github.com/openstack/nova/blob/master/nova/notifications.py#L250 and the openstack recommendation: https://wiki.openstack.org/wiki/NotificationEventExamples

However, Trove emits exists event with a future audit period , which seems incorrect. https://github.com/openstack/trove/blob/master/trove/extensions/mgmt/instances/models.py#L188

At a minimum, this should be fixed to reflect exists event for the recently completed audit period -

Swapping the audit_start and audit_end times(or something similar):

audit_start = utils.isotime(
            now - datetime.timedelta(
                seconds=CONF.exists_notification_ticks * CONF.report_interval),
            subsecond=True)

audit_end = utils.isotime(now, subsecond=True)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/269854

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/269854
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=4d5e8871401e1db046bf5dba0603d788ed9c7a3d
Submitter: Jenkins
Branch: master

commit 4d5e8871401e1db046bf5dba0603d788ed9c7a3d
Author: Victoria Martinez de la Cruz <email address hidden>
Date: Tue Jan 19 17:31:32 2016 -0300

    Make Trove exists events notifs be emitted in current audit period

    Following the guidelines in https://wiki.openstack.org/wiki/NotificationEventExamples,
    we should make sure that the exists notifications are emitted
    with a current audit period instead of the future audit period
    we are currently using.

    Change-Id: I4e19d47ec8827709dbd4b22569877ef2c7c9ea77
    Closes-Bug: #1469860

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/trove 5.0.0.0b3 development milestone.