Crash when renaming a guideline label in a new session

[Mush Man]

When a user renames a guideline's label in a new session, Inkscape will crash. The behaviour is reproducible.

1. Create a guideline and label it
2. Open a new session by opening the file again from Inkscape or the file system
3. Change the label of the guideline made last session and press OK

This does not occur if the guideline from the last session had an empty label. A crash is not encountered when changing guideline labels in the same session.

I have only tested with 0.91 Stable on Windows 8.1 x64.

[su_v (suv-lp)]

Reproduced with Inkscape 0.91 r13725 and 0.91+devel r14220 on OS X 10.7.5.

[su_v (suv-lp)]

Backtrace with 0.91+devel r14212 (debug build)

[su_v (suv-lp)]

Based on tests with archived builds (on OS X 10.7.5):
- not reproduced with Inkscape 0.91+devel r13226, r13227
- reproduced with 0.91+devel r13228;
this crash seems to be a side-effect of the changes in revision 13228 for bug #1299185:
http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/13228

[jazzynico (jazzynico)]

Also reproduced on Windows XP (32bit), Inkscape trunk rev. 14221.

[su_v (suv-lp)]

Raising bug importance (no emergency save file is created -> loss of data).

[jazzynico (jazzynico)]

Related report: Bug #1498444 "Guides flicker under the mouse after changing the label of any guide".

It would be interesting to test the patch from Bug #1498444, comment #11 on Windows or OS X.

[jazzynico (jazzynico)]

Note that the crash doesn't occur consistently on Windows XP (32bit), official devlibs.

[su_v (suv-lp)]

On 2015-10-15 07:21 (+0200), jazzynico wrote:
> It would be interesting to test the patch from Bug #1498444, comment
> #11 on Windows or OS X.

Proposed fix from bug #1498444 tested successfully with 0.91+devel r14415 on OS X 10.7.5 (diff attached, still pending review, see bug #1498444): no crash when editing a guide label in the next session.

[jazzynico (jazzynico)]

@Martin - It seems the cause of the crash is the same as in bug #1498444. Could you please confirm that the guide's label is already freed elsewhere and that removing the extra "free" is the best fix?

[jazzynico (jazzynico)]

Patch applied to the trunk rev. 14426.

Feel free to revert if there's a more elegant or efficient fix.

[su_v (suv-lp)]

Fix backported to 0.91.x in rev 13846.

[LittleBigBrain (braingateway)]

does not crash, but the guideline will disappear. 0.91.0+47