generated configs file has duplicate entries, and missing lib configs

[Ruby Loo]

After the switch to use the oslo.service library[1], the generated etc/ironic/ironic.conf.sample file is weird. It has two entries that are the same for fatal_deprecations, and it is missing backdoor_port (from eventlet_backdoor) and run_external_periodic_tasks (from periodic_task).

I wonder if it is because we're still using tools/config/generate_sample.sh, which is different that what other projects are using/doing.

[1] Change-Id: Iaa1ca0d97b92b9a6858b2c2d50eb514cc2118762

[Sergey Vilgelm (sergey.vilgelm)]

I have fixed the problems related to my patch[1], but we have more problems came from the previous patches and one problem from the oslo.log library. the oslo.log library has the duplicated "fatal_deprecations" options[2], also this option came in third time from the openstack.common.versionutils module.
The "send_single_reply" option is duplicated but int the different sections: [oslo_messaging_qpid] and [oslo_messaging_rabbit]. Those came from the oslo.messaging library.
To fix It I suggest to start from creating a patch with switching for the oslo.log in the ironic to avoid the third line of fatal_deprecations. And create a patch to the oslo.log to fix the duplication of the "fatal_deprecations" option.

[1] Change-Id: Iaa1ca0d97b92b9a6858b2c2d50eb514cc2118762
[2] oslo.log.sample.conf

[Sergey Vilgelm (sergey.vilgelm)]

I have crated the bug for the oslo.log library[1]

[1] https://bugs.launchpad.net/oslo.log/+bug/1469013

[Sergey Vilgelm (sergey.vilgelm)]

oslo review: https://review.openstack.org/#/c/195891/
ironic review for the versionutils module: https://review.openstack.org/#/c/195987/

[Sergey Vilgelm (sergey.vilgelm)]

and the review with updated ironic.conf.sample: https://review.openstack.org/#/c/196002/

[Sergey Vilgelm (sergey.vilgelm)]

Also i made the same error in the other projects which are already merged. I'll associate them with this bug.

[Sergey Vilgelm (sergey.vilgelm)]

cinder review: https://review.openstack.org/#/c/196099/

[Sergey Vilgelm (sergey.vilgelm)]

heat review: https://review.openstack.org/#/c/196106/

[Sergey Vilgelm (sergey.vilgelm)]

sahara review: https://review.openstack.org/#/c/196111/

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sergey Vilgelm (<email address hidden>) on branch: master
Review: https://review.openstack.org/195987

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sergey Vilgelm (<email address hidden>) on branch: master
Review: https://review.openstack.org/196002
Reason: This is useless patch