Image service should not be set in ImageCache constructor
Bug #1468727 reported by
Vladyslav Drok
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ironic |
Fix Released
|
Low
|
Vladyslav Drok | ||
Bug Description
It is possible to initialize ImageCache with specific image service class that will be downloading images. When there was only one type of image links supported - links from glance, it was OK, but now http and file links are also supported, so if ImageCache will be
initialized with specific image service (e.g. glance), it will not be able to download other supported types of images. This should not be allowed. image_service argument in common.images.fetch should be removed for the same reason.
| Changed in ironic: | |
| assignee: | nobody → Vladyslav Drok (vdrok) |
| status: | New → In Progress |
| Changed in ironic: | |
| importance: | Undecided → Low |
Revision history for this message
| Ruby Loo (rloo) wrote | #1 |
| Changed in ironic: | |
| status: | In Progress → Fix Committed |
| Changed in ironic: | |
| milestone: | none → 4.0.0 |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
review: https:/