Remove implicit RequestContext monkey patch

Bug #1468707 reported by Cedric Brandily
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
oslo.db
Fix Released
High
Cedric Brandily

Bug Description

oslo.db 1.12 decorates IMPLICITLY oslo_context RequestContext[1] with session management features when enginefacade module is imported.

We should not AUTOMATICALLY and IMPLICITLY decorate RequestContext as it makes debugging more context, some applications have their own session management in a RequestContext subclass[2][3] or don't want any

[1] https://github.com/openstack/oslo.db/blob/1.12.0/oslo_db/sqlalchemy/enginefacade.py#L782
[2] https://github.com/openstack/neutron/blob/master/neutron/context.py
[3] at least until oslo.db>1.12 is added in neutron requirements.txt

Revision history for this message
Cedric Brandily (cbrandily) wrote :

PS: implicit monkey patch has broken neutron: https://review.openstack.org/194844

Changed in oslo.db:
status: New → Triaged
importance: Undecided → High
assignee: nobody → Cedric Brandily (cbrandily)
status: Triaged → Fix Committed
Changed in oslo.db:
milestone: none → 2.0.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.