Loading block wouldn't disappear after using compound key to click link

Bug #1468706 reported by Chung Chih, Hung
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Jason Pan

Bug Description

When user want to using compound key to open link in new tab such as open instances page in new tab.
He will hold control key and click link by left button of mouse. Then the page will be opened in new tab.
But original page will occur loading block. And it will never disappear.
This situation will happened either using middle button of mouse to click link or hold some other compound key (such as esc key or shift key) and click link.
And not all of link will occur this bugs. It was exist at those links which are located at left navigation block.

When user click link, maybe UI will assume browser to send request and receive the response.
But browser will not send any request in this page. Therefore the loading block will stay there forever.

This bug was exist in Chrome, Safari and Firefox.

Changed in horizon:
assignee: nobody → inwinSTACK inc. (inwinstack)
Revision history for this message
Jason Pan (jason-p-c) wrote :

Is your OS are MAC OSX?
I didn't found that issue in Ubuntu 14.04, but in OSX 10.11.

Changed in horizon:
assignee: inwinSTACK (inwinstack) → Jason Pan (jason-p-c)
Revision history for this message
Chung Chih, Hung (lyanchih) wrote :

Yes, I'm using MAC OSX 10.10.4.

Jason Pan (jason-p-c)
Changed in horizon:
status: New → Fix Committed
Revision history for this message
Rob Cresswell (robcresswell-deactivatedaccount) wrote :
Changed in horizon:
importance: Undecided → Low
milestone: none → liberty-2
status: Fix Committed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/201057
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=d533eb58f4fad23d5583f136a26f32546c318467
Submitter: Jenkins
Branch: master

commit d533eb58f4fad23d5583f136a26f32546c318467
Author: JasonPan <email address hidden>
Date: Mon Jul 13 17:19:12 2015 +0800

    Fix the loading block wouldn't disappear in Mac OS X

    In linux, Windows open new tab by Ctrl/Shift + mouse click. But, in
    Mac OS X is using Command key + mouse click. So, when using Mac OS X
    to open new tab by Command key + mouse click, loading block show up
    function will not be excaped, and the loading block don't disappear.

    Add "ev.metaKey" to check Command key is pressed, and don't execute
    loading block show up function.

    Closes-Bug: #1468706
    Change-Id: I2f38b5e19137403d5191492b68f39fba2cdc6863

Changed in horizon:
status: In Progress → Fix Committed
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: liberty-2 → 8.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.