APIv2 does not reject requests that have invalid filters

Bug #1468452 reported by Graham Hayes
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Designate
Fix Released
High
Mimi Lee

Bug Description

Currently in each of the controllers in the v2 API we have a list of supported filters

We currently take filtering requests for all fields, and if they are not in the list discard that filter.

We should be returning a 400 Bad Request, and informing the user of which filter is not supported.

Tags: api
sonu (sonu-bhumca11)
Changed in designate:
assignee: nobody → sonu (sonu-bhumca11)
Mimi Lee (mimi-lee)
Changed in designate:
assignee: sonu (sonu-bhumca11) → Mimi Lee (mimi-lee)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (master)

Fix proposed to branch: master
Review: https://review.openstack.org/200651

Changed in designate:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (master)

Reviewed: https://review.openstack.org/200651
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=01b170db9fb4ecdafb023a98890f2666c74a5567
Submitter: Jenkins
Branch: master

commit 01b170db9fb4ecdafb023a98890f2666c74a5567
Author: mimi8890 <email address hidden>
Date: Fri Jul 10 18:31:01 2015 +0000

    Reject invalid filters

    Returns an error when a call is made with a filter that is not
    supported. Added unit tests.

    Change-Id: Ic712f8d145cd6059d9e8af4df3efaa113acb7e08
    Closes-bug: 1468452

Changed in designate:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in designate:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in designate:
milestone: liberty-2 → 1.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.