[dashboard] get rid of django-floppyforms dependency

Bug #1468342 reported by Victor Ryzhenkin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Fix Released
High
Kirill Zaitsev

Bug Description

This requirement doesn't match global-requirements of Openstack and blocking activity for enabling Openstack Proposal Bot.

We need to find a way to get rid of this dependency.

Tags: dashboard
Revision history for this message
Kirill Zaitsev (kzaitsev) wrote :

As a workaround we can copy the code we want into murano-dashboard, although that requires some research.

tags: added: dashboard
Revision history for this message
Ekaterina Chernova (efedorova) wrote :

The plan is:
1) remove floppy-forms from dashboard
    This will affect dynamic UI, but since we are introducing new version anyway - it's ok
2) replace floppy form usage during porting mysql app from app-incubator to murano-apps.
    this app is not working with the latest murano and it's needed only for that

Changed in murano:
status: Confirmed → Fix Released
status: Fix Released → Confirmed
Changed in murano:
milestone: liberty-1 → liberty-2
Changed in murano:
assignee: nobody → Kirill Zaitsev (kzaitsev)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano-dashboard (master)

Reviewed: https://review.openstack.org/198796
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=b21538e2a30b94a26db3f1c09f9c4897f41a2fea
Submitter: Jenkins
Branch: master

commit b21538e2a30b94a26db3f1c09f9c4897f41a2fea
Author: Kirill Zaitsev <email address hidden>
Date: Mon Jul 6 18:44:03 2015 +0300

    Remove unused and unsupported table field

    This commit removes any mention of table field from dynamic_ui and
    removes floppyforms from requirements.

    'table' field was introduced for MsSqlClusterServer service, that
    changed significantly since then and does not use table field anymore.
    See
    https://github.com/murano-project/murano-app-incubator/blob/master/io.murano.windows.SqlServerCluster/UI/ui.yaml
    for more details (even though the repository is deprecated).

    Since no app available today uses this type of field, and no tests exist
    for this type of field. There is no way to test, that it works correctly,
    therefore it is very hard to transfer critical parts from floppyforms to
    murano-dashboard.

    'table' field depends on django-floppyforms, which is not
    present in global-requirements, which is problematic and prevents us
    from enabling proposal bot in murano-dashboard.

    'table' field was never documented, so no documentation change is
    required.

    Change-Id: I638c722c2bdde411aaefa02f3d4027119de0e0bd
    Closes-Bug: #1468342

Changed in murano:
status: In Progress → Fix Committed
Changed in murano:
status: Fix Committed → Fix Released
Changed in murano:
milestone: liberty-2 → 1.0.0
Changed in murano:
milestone: 1.0.0 → 1.0.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.