recovery update screen lacks warning

[Ondrej Kubik]

When in recovery installing OTA updates, screen only shows infinite progress and animation.

There should be also warning to user, not to disturb update in any way, such as trying to power phone off, removing battery.....
Preferably progress or more verbose could be added.

Tested on Stable arale v2

[Yuan-Chen Cheng (ycheng-twn)]

we need to be sure that we have font for languages like Chinese character which the font set is much bigger.

[Ondrej Kubik (ondrak)]

Interesting question is if text in English is enough.
Because in recovery we don't have language variants, also in case of factory reset operations, we won't even have any settings to determine language.

[Jason Yen (jasonyen)]

Beijing QA team commented the Mi phone support Simplified Chinese, Traditional Chinese and English for recovery mode . So maybe we do need the Simplified Chinese.

[Yuan-Chen Cheng (ycheng-twn)]

The message string in plan is:

"System updating ! Do not disturb in any way, and to keep power plugged."
"系統更新中 ! 請勿干擾並儘量插上外接電源。"
"系统更新中 ! 请勿干扰并尽量插上外接电源。"

Please review above strings !

[Jason Yen (jasonyen)]

Suggest to change as the following.

"System updating ! Do not disturb in any way, and to keep power plugged."
"系統更新中 ! 請勿干擾並插上外接電源。"
"系统更新中 ! 请勿干扰并插上外接电源。"

[Pat McGowan (pat-mcgowan)]

adding pt for string guidance

[You-Sheng Yang (vicamo)]

https://code-review.tangxi-git.canonical.com/704
https://code-review.tangxi-git.canonical.com/703

I copied that txt_err_bat.png as txt_warn_donot_unplug_power.png as a place holder. Final artwork is required to finish this task. The txt_warn_donot_unplug_power.png I use right now is of 1080x127, and its height may reach at max 700 pixels since MX4 has a 1152x1920 display.

[You-Sheng Yang (vicamo)]

Example image for the warning message one. Background color should be rgb:0x2c001e instead.

[You-Sheng Yang (vicamo)]

"System updating! Do not disturb in any way, and to keep power plugged."
"系統更新中！請勿干擾並插上外接電源。"
"系统更新中！请勿干扰并插上外接电源。"

Remove an extra space before '!' in en str, and use full width '!' instead in both traditional/simplified Chinese to match the full width period symbol used at the end. My 2 cents.

[You-Sheng Yang (vicamo)]

I think we can determine system default language from system properties "ro.product.locale.language" and "ro.product.locale.region", so we don't have to display all three languages at the same time. They are "zh" and "CN" when MZ_INTERNATIONAL equals to zh_CN. Note these ro properties are etched in ${PRODUCT_OUT}/recovery/root/default.prop and different value pairs here mean different recovery.img built, and therefore different factory images, different device tarballs, etc. Although this should have been the case anyway.

Display all the three strings by turns is also possible. Any other idea or what's our preference now?

[Matthew Paul Thomas (mpt)]

It's really unfortunate that you're trying to design something here without getting help from a designer. Any good designer would ask two important questions.

"There should be also warning to user, not to disturb update in any way"

The first question is: Why do you need that at all? There isn't an equivalent warning when installing a system update on iOS, for example. What is wrong with Ubuntu that it needs one?

"not to disturb update in any way, such as trying to power phone off"

There is no UI for powering the phone off when you are installing an update, and nothing bad (that I know of) happens if you do.

"removing battery....."

Removing the battery could cause data loss at any time, not just when you're installing updates. Should we have an equivalent warning on screen on all the time? If not, why show it here?

As for the suggested text itself:

"System updating!"

The system updates every month; it is not that exciting. Even if the warning was necessary at all, an exclamation mark would be crass. (UI text instead uses bold, larger text, and occasionally color to indicate danger.)

"Do not disturb in any way"

What does this mean? Am I allowed to put it in my pocket? Am I allowed to touch the screen?

"and to keep power plugged"

Even if the warning was necessary at all, this phrase would not be: the device does not, in fact, need to be connected to power during a system update. On the contrary, the update process checks that you have enough battery charge before it starts.

And even if the warning *and* this phrase were both necessary, "Do not disturb in any way, and to keep power plugged" is grammatically incorrect in three ways: (1) it suggests that you should *not* keep power connected, when you meant the opposite; (2) the "to" shouldn't be there, and (3) "plugged" is not a complete verb phrase in the way that "connected" or "plugged in" are. Better would be "keep connected to power" -- though again, that isn't necessary in the first place.

And finally, why is the text not using the Ubuntu font?

"Preferably progress or more verbose could be added."

This is the second question a good designer would ask: Can we use something else instead of text, so that the UI is calmer and less bothersome? In this case we can. You are, commendably, trying to guard against the possibility that someone will see nothing happening and think that the update is stuck. But the reason they'll think it's stuck is that the specified determinate progress is not implemented <https://wiki.ubuntu.com/SoftwareUpdates#restart-and-install>, so it looks exactly the same after three minutes as it did after one minute. Please just fix that, rather than adding alarming text.

[You-Sheng Yang (vicamo)]

@mpt, I don't accept the first paragraph in your reply. I mentioned "Final artwork is required" in https://bugs.launchpad.net/ubuntu/+source/android/+bug/1468311/comments/7 , "Example image ..." in https://bugs.launchpad.net/ubuntu/+source/android/+bug/1468311/comments/8 , and I did asked @jasonyen if we need further response from artwork designers before creating those images.

I'll only respond to technical questions from now on.

[Matthew Paul Thomas (mpt)]

I'm sorry, I didn't realize that "adding pt" was referring to me. So Pat did ask for help from a designer.

For the reasons I gave, I could be wrong, but I doubt that any warning should appear during flashing at all. The main reason people would try to remove the battery here, rather than at any other time, is because they think the update is stuck. Correct? We can fix that by reassuring people that it is not stuck -- showing a determinate progress bar during the flashing, which is the polite thing to do anyway. And we have extra incentive to take that approach, since this screen is difficult to localize.

So, to extract just my technical questions from earlier:

1. iOS, and Windows Phone, do not have any warning during system update. What is different about Ubuntu? Is it that Ubuntu is more likely to be damaged if someone tries to interrupt a system update? Or is it just that the lack of progress makes people more likely to try?

2. Is removing the battery more dangerous when flashing than it is during normal use? If so, is this a problem that will be solved with Snappy?

3. What is "Do not disturb" intended to cover, besides removing the battery? What things can users actually do, during an update, that they should not do?

[Jason Yen (jasonyen)]

@mpt and Vicamo,

Thanks for the help with this request. After the follow up with the certification lab for more clarification. They accept the put the notice in the user manual. So we don't need this change any more. Mark this bug as won't fix.