DM: improve names used in generated configuration

[Nischal Sheth]

Following changes should be implemented:

1. Consistently use __contrail__ as prefix not just anywhere in the name.
For example sv-__contrail__606ba should become __contrail__-sv-606ba.

2. The dynamic-tunnels name should be changed from __contrail__ to
__contrail-asn-nnnnn, where nnnnn is the global ASN for the contrail
cluster.

3. Similar to 2 above, the __contrail__ and __contrail_external__ groups
should also contain the global ASN.

4. Community names should have __contrail__ prefix to valid conflicts with
manually configured communities.

5. The RI and policy names should have the name before the uuid so that
it becomes easier to find them using JUNOS CLI - auto-completion will
work better if the name is before the uuid string.

6. After JUNOS limitation with service-set and rule names is fixed, we
should use the BMS IP and FIP in the snat and dnat rule name instead
of just using a number. That will minimize name changes (and reduce
chances of data plane churn) when a FIP is added/removed from BMS.
The dots in address can be replaced with underscores.

7. Filter names for redirect to nat RIs should

8. Filter name redirect_to_public_vrf_filter should be modified to
__contrail__redirect-to-public-vrfs.

9. Consistently use hyphen (-) as separator in generated names. We
currently use a mix of hypen and underscore arbitrarily. As a convention,
the only place we should use underscore is for the __contrail__ prefix.

10. Filter name used to direct traffic to nat should contain the vn name.
Change redirect_to___contrail__606ba096-d7c8-404a-9455-fce8747f69_vrf to
___contrail__-redirect-to-vn5-606ba096-d7c8-404a-9455-fce8747f69-nat.

[OpenContrail Admin (ci-admin-f)]

bug update...

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/29108
Submitter: Suresh Balineni (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/29108
Committed: http://github.org/Juniper/contrail-controller/commit/9a45453ab1941dc4c97fd606144caedc55bfc3bf
Submitter: Zuul (<email address hidden>)
Branch: master

commit 9a45453ab1941dc4c97fd606144caedc55bfc3bf
Author: sbalineni <email address hidden>
Date: Fri Feb 24 12:30:30 2017 -0800

[DM]: Improved naming conventions for DM generated JUNOS config

Change-Id: If24cf289800cfd065e0e77943c388e954ccc8713
Partial-Bug: #1468210