setting `enable_instance_password = True` causes a json scheme validation failure

[Kevin Carter]

When running tempest from master, against an OpenStack cloud built from Master (liberty), Kilo, or Juno tempest will fail if the nova.conf flag `enable_instance_password` is set to "True". The tests expect that the scheme returned from nova will be without the adminPass field.

This is an example of the error:
http://logs.openstack.org/44/194344/1/check/os-ansible-deployment-dsvm-check-commit/8622cab/console.html#_2015-06-22_21_26_49_929

It seems that the scheme validation happening @ tempest_lib/common/rest_client.py", line 811 is too restrictive.

[Ghanshyam Mann (ghanshyammann)]

Tempest also has config flag for same feature and that should be in sync with nova - https://github.com/openstack/tempest/blob/master/etc/tempest.conf.sample#L416

Based on that flag Tempest trigger the different schema.

What's the value of this flag in tempest config? It should be True if same is there on Nova side.

[Kevin Carter (kevin-carter)]

we have that flag set to false in tempest by default and true in nova, which i guess is the root cause of the issues. However, I will say that this has only become a problem recently which i guess is related to the fixing/enhancing of the scheme validation now happening in the head of tempest-lib and tempest.

I've marked the issue as invalid for now here, as its certainly a configuration problem on our side. Thanks for the review/feedback.

[Ghanshyam Mann (ghanshyammann)]

Yes, currently Tempest block additional properties in schema.

That's why this configuration issue on your side was hidden before :).

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: kilo
Review: https://review.openstack.org/195222

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/195222
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=a06a5125b98e064d6042ebeac0b328d341ee0411
Submitter: Jenkins
Branch: kilo

commit a06a5125b98e064d6042ebeac0b328d341ee0411
Author: kevin <email address hidden>
Date: Tue Jun 23 14:38:12 2015 -0500

    Added options for enabling instance_passwords

    The nova.conf and tempest.conf option for `enable_instance_password` has been
    added as a default. This option has a default of True in nova but false in tempest.
    This causes temptest to fail scheme validation on newer versions of temptest.
    To fix this issue the option being added with a default value of True for both
    tempest and nova.

    Change-Id: I19f5da9820f2367b3d8dd0a7f215aa3f3ea5f611
    Partial-Bug: #1468061
    (cherry pick from commit c068b965a11ad559aad0c6052ed7e58eff4dcd64)