Juniper Openstack

BgpTable should not be deleted if it has pending walks

Bug #1468052 reported by Nischal Sheth
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R2.0
Fix Committed
Medium
Nischal Sheth
Juniper Openstack r2.02
R2.1
Fix Released
Medium
Nischal Sheth
Juniper Openstack r2.11 "r2.11"
R2.20
Fix Released
Medium
Nischal Sheth
Juniper Openstack r2.21
Trunk
Fix Committed
Medium
Nischal Sheth
Juniper Openstack r3.0-fcs

Bug Description

Found by inspection that a table can get deleted even if it has pending
walks. This will cause access to freed memory when DBTableWalker::Worker
task runs.

See original description
Nischal Sheth (nsheth)
description: updated
Nischal Sheth (nsheth)
tags: removed: base vrouter
summary: - DBTable should not be deleted if it has pending walks
+ BgpTable should not be deleted if it has pending walks
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/11972
Submitter: Nischal Sheth (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.20

Review in progress for https://review.opencontrail.org/11973
Submitter: Nischal Sheth (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.1

Review in progress for https://review.opencontrail.org/11974
Submitter: Nischal Sheth (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.0

Review in progress for https://review.opencontrail.org/11975
Submitter: Nischal Sheth (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/11972
Committed: http://github.org/Juniper/contrail-controller/commit/d4b88a849c61db7cc887166311ca4a328c432ad2
Submitter: Zuul
Branch: master

commit d4b88a849c61db7cc887166311ca4a328c432ad2
Author: Nischal Sheth <email address hidden>
Date: Mon Jun 22 17:33:21 2015 -0700

Don't delete BgpTable till all walkers are done

Add infra to keep track of number of walkers per DBTableBase and invoke
the RetryDelete method when the last walker is done. Modify BgpTable to
use the new infra.

Change-Id: Id33c84c7fac76ab99fdf919045da280b0b5038b4
Closes-Bug: 1468052

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/11975
Committed: http://github.org/Juniper/contrail-controller/commit/b1bde6bef19bf490648f3c8ebcb071dce21ee84e
Submitter: Zuul
Branch: R2.0

commit b1bde6bef19bf490648f3c8ebcb071dce21ee84e
Author: Nischal Sheth <email address hidden>
Date: Mon Jun 22 17:33:21 2015 -0700

Don't delete BgpTable till all walkers are done

Add infra to keep track of number of walkers per DBTableBase and invoke
the RetryDelete method when the last walker is done. Modify BgpTable to
use the new infra.

Change-Id: Id33c84c7fac76ab99fdf919045da280b0b5038b4
Closes-Bug: 1468052

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/11973
Committed: http://github.org/Juniper/contrail-controller/commit/07a60405761f849c2a0a23ddc7a812c905f41b89
Submitter: Zuul
Branch: R2.20

commit 07a60405761f849c2a0a23ddc7a812c905f41b89
Author: Nischal Sheth <email address hidden>
Date: Mon Jun 22 17:33:21 2015 -0700

Don't delete BgpTable till all walkers are done

Add infra to keep track of number of walkers per DBTableBase and invoke
the RetryDelete method when the last walker is done. Modify BgpTable to
use the new infra.

Change-Id: Id33c84c7fac76ab99fdf919045da280b0b5038b4
Closes-Bug: 1468052

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/11974
Committed: http://github.org/Juniper/contrail-controller/commit/3c32bac100852a7b71362bed5ae559687dbd3e3e
Submitter: Zuul
Branch: R2.1

commit 3c32bac100852a7b71362bed5ae559687dbd3e3e
Author: Nischal Sheth <email address hidden>
Date: Mon Jun 22 17:33:21 2015 -0700

Don't delete BgpTable till all walkers are done

Add infra to keep track of number of walkers per DBTableBase and invoke
the RetryDelete method when the last walker is done. Modify BgpTable to
use the new infra.

Change-Id: Id33c84c7fac76ab99fdf919045da280b0b5038b4
Closes-Bug: 1468052

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.