compute monitors should be loaded via stevedore
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
Wishlist
|
Jay Pipes |
Bug Description
The monitor plugins in /nova/compute/
This would have the side benefit of us being able to deprecate the following CONF options:
compute_
cfg.
cfg.
]
Since stevedore's ExtensionManager loads extensions via standard Python setuptools entry_points.
Changed in nova: | |
status: | Triaged → In Progress |
Changed in nova: | |
milestone: | none → liberty-2 |
status: | Fix Committed → Fix Released |
Changed in nova: | |
milestone: | liberty-2 → 12.0.0 |
Reviewed: https:/ /review. openstack. org/196181 /git.openstack. org/cgit/ openstack/ nova/commit/ ?id=c41db608fe3 cd75c5925bb7693 261ac8379737f0
Committed: https:/
Submitter: Jenkins
Branch: master
commit c41db608fe3cd75 c5925bb7693261a c8379737f0
Author: Jay Pipes <email address hidden>
Date: Wed Jun 24 17:26:28 2015 -0400
Rework monitor plugin interface and API
In order to prepare for the stevedore-ization of the compute monitor
plugins, and to clean up the overly complex monitor API, this patch
breaks out the base monitor plugin into a much simpler class that has
the following methods:
- get_metric_names(), which remains unchanged in its to_list( ) which is a non-overrideable method on the objects. MonitorMetricLi st object supplied as the parameter
purpose from the original ResourceMonitorBase class
- get_metric(name), which returns a (value, timestamp) tuple for
a supplied metric name
- add_metrics_
base plugin class that adds a set of metrics to a
nova.
There is a base class called nova.compute. monitors. base.CPUMonitor Base
that simply returns the appropriate CPU monitor metric name constants
for the get_metric_names() method.
The directory structure of the monitor plugins and the module naming for compute. monitors. base.CPUMonitor Base and uses the call to the cpu_stats( ) to grab CPU-centric metrics on a
the lone in-tree is changed to better represent what the directories and
files contain. The lone in-tree plugin is a monitor that inherits from
nova.
hypervisor's get_host_
periodic basis.
Change-Id: I3f2e8eca6ce43b 07b3c8b430b8576 be4f0d3f909
Partial-bug: 1468012