[image] rename cert_required to cafile_required

Bug #1467951 reported by Mark Vanderwiel
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack + Chef
Fix Released
Wishlist
Sharat Sharma

Bug Description

A rename would make this more consistent:

# Specify server whether SSL certificate is required
default['openstack']['image']['ssl']['cert_required'] = false
# Path of the CA cert file for SSL. Only use if client certificate is required
default['openstack']['image']['ssl']['ca_file'] = "#{node['openstack']['image']['ssl']['basedir']}/certs/sslca.pem"

to

# Specify server whether SSL certificate is required
default['openstack']['image']['ssl']['cafile_required'] = false
# Path of the CA cert file for SSL. Only use if client certificate is required
default['openstack']['image']['ssl']['ca_file'] = "#{node['openstack']['image']['ssl']['basedir']}/certs/sslca.pem"

See comments in this review: https://review.openstack.org/#/c/188576/6/attributes/default.rb

Tags: image
Jan Klare (j-klare)
Changed in openstack-chef:
status: Triaged → Confirmed
willy lin (willy-l)
Changed in openstack-chef:
assignee: nobody → willy lin (willy-l)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-image (master)

Fix proposed to branch: master
Review: https://review.openstack.org/209720

Changed in openstack-chef:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on cookbook-openstack-image (master)

Change abandoned by willy lin (<email address hidden>) on branch: master
Review: https://review.openstack.org/209720

willy lin (willy-l)
Changed in openstack-chef:
assignee: willy lin (willy-l) → nobody
Changed in openstack-chef:
status: In Progress → Triaged
summary: - [image] rename cert_required to cacert_required
+ [image] rename cert_required to cafile_required
description: updated
description: updated
Changed in openstack-chef:
assignee: nobody → Sharat Sharma (sharat-sharma)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-image (master)

Fix proposed to branch: master
Review: https://review.openstack.org/315915

Changed in openstack-chef:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-image (master)

Reviewed: https://review.openstack.org/315915
Committed: https://git.openstack.org/cgit/openstack/cookbook-openstack-image/commit/?id=fce19da1aada86833084633bfab8fd991d7a1c3c
Submitter: Jenkins
Branch: master

commit fce19da1aada86833084633bfab8fd991d7a1c3c
Author: sharat.sharma <email address hidden>
Date: Fri May 13 12:27:39 2016 +0530

    Removed cert_required field which is no longer in use.

    Change-Id: Idc20e67af363312154a9f6f79088b0b7503b514a
    Closes-Bug: #1467951

Changed in openstack-chef:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cookbook-openstack-image ocata-eol

This issue was fixed in the openstack/cookbook-openstack-image ocata-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.