Assertion failure when populating music folder
Bug #1467751 reported by
Michi Henning
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Thumbnailer |
Fix Released
|
Critical
|
James Henstridge | ||
Bug Description
I just got this while starting the music app after having untarred a bunch of mp3 files into the Music folder:
Activating service name='com.
thumbnailer-
Successfully activated service 'com.canonical.
thumbnailer-
thumbnailer-
thumbnailer-
Related branches
lp:~jamesh/thumbnailer/bug-1467751
- PS Jenkins bot (community): Approve (continuous-integration)
- Michi Henning (community): Approve
-
Diff: 66 lines (+2/-9)1 file modifiedsrc/service/handler.cpp (+2/-9)
- PS Jenkins bot (community): Approve (continuous-integration)
- Unity Team: Pending requested
-
Diff: 30692 lines (+25137/-3830)204 files modifiedCMakeLists.txt (+107/-31)
COPYING.GPL (+674/-0)
CTestCustom.cmake.in (+17/-0)
HACKING (+121/-0)
cmake/XEnableCoverageReport.cmake (+203/-0)
cmake/coverage.cmake (+0/-34)
data/CMakeLists.txt (+0/-1)
data/com.canonical.Unity.Thumbnailer.gschema.xml (+67/-0)
debian/changelog (+8/-0)
debian/control (+12/-28)
debian/copyright (+22/-2)
debian/libthumbnailer-dev.install (+0/-3)
debian/libthumbnailer0.install (+0/-2)
debian/libthumbnailer0.symbols (+0/-7)
debian/rules (+3/-0)
debian/thumbnailer-service.install (+2/-0)
include/CMakeLists.txt (+0/-11)
include/core/cache_codec.h (+50/-0)
include/core/cache_discard_policy.h (+41/-0)
include/core/cache_events.h (+103/-0)
include/core/internal/cache_event_indexes.h (+46/-0)
include/core/internal/persistent_string_cache_impl.h (+191/-0)
include/core/internal/persistent_string_cache_stats.h (+237/-0)
include/core/optional.h (+35/-0)
include/core/persistent_cache.h (+3104/-0)
include/core/persistent_cache_stats.h (+230/-0)
include/core/persistent_string_cache.h (+726/-0)
include/internal/artdownloader.h (+44/-16)
include/internal/artreply.h (+60/-0)
include/internal/audioimageextractor.h (+0/-41)
include/internal/check_access.h (+42/-0)
include/internal/config.h.in (+4/-7)
include/internal/file_io.h (+51/-0)
include/internal/gobj_memory.h (+170/-65)
include/internal/httpdownloader.h (+25/-13)
include/internal/image.h (+82/-0)
include/internal/imageextractor.h (+59/-22)
include/internal/imagescaler.h (+0/-55)
include/internal/lastfmdownloader.h (+0/-45)
include/internal/make_directories.h (+44/-0)
include/internal/mediaartcache.h (+0/-61)
include/internal/raii.h (+55/-0)
include/internal/safe_strerror.h (+38/-0)
include/internal/settings.h (+72/-0)
include/internal/soupdownloader.h (+0/-40)
include/internal/thumbnailcache.h (+0/-50)
include/internal/thumbnailer.h (+128/-47)
include/internal/trace.h (+45/-0)
include/internal/ubuntuserverdownloader.h (+49/-21)
include/service/dbus_names.h (+40/-0)
include/thumbnailer.pc.in (+0/-10)
plugins/Ubuntu/Thumbnailer.0.1/CMakeLists.txt (+11/-2)
plugins/Ubuntu/Thumbnailer.0.1/albumartgenerator.cpp (+46/-52)
plugins/Ubuntu/Thumbnailer.0.1/albumartgenerator.h (+15/-8)
plugins/Ubuntu/Thumbnailer.0.1/artgeneratorcommon.cpp (+45/-19)
plugins/Ubuntu/Thumbnailer.0.1/artgeneratorcommon.h (+12/-6)
plugins/Ubuntu/Thumbnailer.0.1/artistartgenerator.cpp (+46/-52)
plugins/Ubuntu/Thumbnailer.0.1/artistartgenerator.h (+18/-11)
plugins/Ubuntu/Thumbnailer.0.1/plugin.cpp (+65/-24)
plugins/Ubuntu/Thumbnailer.0.1/plugin.h (+14/-7)
plugins/Ubuntu/Thumbnailer.0.1/thumbnailerimageresponse.cpp (+117/-0)
plugins/Ubuntu/Thumbnailer.0.1/thumbnailerimageresponse.h (+68/-0)
plugins/Ubuntu/Thumbnailer.0.1/thumbnailgenerator.cpp (+67/-77)
plugins/Ubuntu/Thumbnailer.0.1/thumbnailgenerator.h (+25/-16)
src/CMakeLists.txt (+43/-36)
src/artdownloader.cpp (+40/-0)
src/audioimageextractor.cpp (+0/-58)
src/check_access.cpp (+83/-0)
src/core/CMakeLists.txt (+13/-0)
src/core/internal/CMakeLists.txt (+5/-0)
src/core/internal/persistent_string_cache_impl.cpp (+1646/-0)
src/core/persistent_cache_stats.cpp (+219/-0)
src/core/persistent_string_cache.cpp (+239/-0)
src/file_io.cpp (+194/-0)
src/image.cpp (+484/-0)
src/imageextractor.cpp (+149/-89)
src/imagescaler.cpp (+0/-163)
src/lastfmdownloader.cpp (+0/-95)
src/libthumbnailer.map (+0/-15)
src/make_directories.cpp (+51/-0)
src/mediaartcache.cpp (+0/-225)
src/safe_strerror.cpp (+72/-0)
src/service/CMakeLists.txt (+20/-17)
src/service/admininterface.cpp (+141/-0)
src/service/admininterface.h (+65/-0)
src/service/admininterface.xml (+41/-0)
src/service/bus.xml (+9/-0)
src/service/com.canonical.Thumbnailer.service.in (+0/-1)
src/service/credentialscache.cpp (+187/-0)
src/service/credentialscache.h (+81/-0)
src/service/dbusinterface.cpp (+246/-237)
src/service/dbusinterface.h (+71/-27)
src/service/dbusinterface.xml (+14/-11)
src/service/handler.cpp (+443/-0)
src/service/handler.h (+91/-0)
src/service/inactivityhandler.cpp (+63/-0)
src/service/inactivityhandler.h (+49/-0)
src/service/main.cpp (+80/-43)
src/service/ratelimiter.cpp (+69/-0)
src/service/ratelimiter.h (+63/-0)
src/service/stats.cpp (+105/-0)
src/service/stats.h (+75/-0)
src/settings.cpp (+170/-0)
src/soupdownloader.cpp (+0/-46)
src/thumbnailcache.cpp (+0/-371)
src/thumbnailer-admin/CMakeLists.txt (+33/-0)
src/thumbnailer-admin/action.h (+66/-0)
src/thumbnailer-admin/clear.cpp (+115/-0)
src/thumbnailer-admin/clear.h (+50/-0)
src/thumbnailer-admin/dbus_connection.cpp (+58/-0)
src/thumbnailer-admin/dbus_connection.h (+57/-0)
src/thumbnailer-admin/get_local_thumbnail.cpp (+113/-0)
src/thumbnailer-admin/get_local_thumbnail.h (+52/-0)
src/thumbnailer-admin/get_remote_thumbnail.cpp (+129/-0)
src/thumbnailer-admin/get_remote_thumbnail.h (+53/-0)
src/thumbnailer-admin/parse_size.cpp (+62/-0)
src/thumbnailer-admin/parse_size.h (+39/-0)
src/thumbnailer-admin/show_stats.cpp (+223/-0)
src/thumbnailer-admin/show_stats.h (+55/-0)
src/thumbnailer-admin/shutdown.cpp (+74/-0)
src/thumbnailer-admin/shutdown.h (+47/-0)
src/thumbnailer-admin/thumbnailer-admin.cpp (+143/-0)
src/thumbnailer-admin/util.cpp (+79/-0)
src/thumbnailer-admin/util.h (+49/-0)
src/thumbnailer.cpp (+735/-303)
src/trace.cpp (+103/-0)
src/ubuntuserverdownloader.cpp (+240/-74)
src/vs-thumb/CMakeLists.txt (+13/-0)
src/vs-thumb/thumbnailextractor.cpp (+430/-0)
src/vs-thumb/thumbnailextractor.h (+56/-0)
src/vs-thumb/vs-thumb.cpp (+90/-207)
tests/CMakeLists.txt (+52/-30)
tests/basic.cpp (+0/-212)
tests/check_access/CMakeLists.txt (+4/-0)
tests/check_access/check_access_test.cpp (+64/-0)
tests/copyright/CMakeLists.txt (+6/-0)
tests/copyright/check_copyright.sh (+53/-0)
tests/core/CMakeLists.txt (+8/-0)
tests/core/internal/CMakeLists.txt (+1/-0)
tests/core/internal/persistent_string_cache_impl/CMakeLists.txt (+5/-0)
tests/core/internal/persistent_string_cache_impl/persistent_string_cache_impl_test.cpp (+1980/-0)
tests/core/persistent_cache/CMakeLists.txt (+5/-0)
tests/core/persistent_cache/persistent_cache_test.cpp (+1413/-0)
tests/core/persistent_string_cache/CMakeLists.txt (+11/-0)
tests/core/persistent_string_cache/persistent_string_cache_test.cpp (+469/-0)
tests/core/persistent_string_cache/speed_test.cpp (+212/-0)
tests/dbus/CMakeLists.txt (+12/-0)
tests/dbus/dbus_test.cpp (+548/-0)
tests/download/CMakeLists.txt (+11/-0)
tests/download/download_test.cpp (+216/-135)
tests/file_io/CMakeLists.txt (+4/-0)
tests/file_io/file_io_test.cpp (+155/-0)
tests/gobj_ptr/CMakeLists.txt (+3/-0)
tests/gobj_ptr/gobj_ptr_test.cpp (+166/-129)
tests/headers/CMakeLists.txt (+45/-0)
tests/headers/compile_headers.py (+169/-0)
tests/image/CMakeLists.txt (+4/-0)
tests/image/image_test.cpp (+368/-0)
tests/media/bad_image.jpg (+1/-0)
tests/mediaartcachetest.cpp (+0/-169)
tests/qml/CMakeLists.txt (+11/-0)
tests/qml/Fixture.qml (+109/-0)
tests/qml/qml_test.cpp (+78/-0)
tests/qml/tst_albumart.qml (+41/-66)
tests/qml/tst_embedded_albumart.qml (+10/-0)
tests/qml/tst_photo.qml (+61/-0)
tests/safe_strerror/CMakeLists.txt (+4/-0)
tests/safe_strerror/safe_strerror_test.cpp (+29/-0)
tests/server/images/artist_album.png (+1/-0)
tests/server/images/sia_fear.txt (+1/-0)
tests/server/images/sia_fear_album.txt (+1/-0)
tests/server/server.py (+96/-0)
tests/settings/CMakeLists.txt (+4/-0)
tests/settings/settings_test.cpp (+146/-0)
tests/slow-vs-thumb/CMakeLists.txt (+11/-0)
tests/slow-vs-thumb/slow-vs-thumb_test.cpp (+63/-0)
tests/slow-vs-thumb/slow/vs-thumb (+3/-0)
tests/testsetup.h.in (+29/-3)
tests/thumbnailer-admin/CMakeLists.txt (+16/-0)
tests/thumbnailer-admin/thumbnailer-admin_test.cpp (+616/-0)
tests/thumbnailer/CMakeLists.txt (+14/-0)
tests/thumbnailer/thumbnailer_test.cpp (+903/-0)
tests/thumbnailer/vs-thumb-crash/vs-thumb (+3/-0)
tests/thumbnailer/vs-thumb-exit-1/vs-thumb (+3/-0)
tests/thumbnailer/vs-thumb-exit-2/vs-thumb (+3/-0)
tests/thumbnailer/vs-thumb-exit-99/vs-thumb (+3/-0)
tests/utils/CMakeLists.txt (+34/-0)
tests/utils/artserver.cpp (+59/-0)
tests/utils/artserver.h (+34/-0)
tests/utils/dbusserver.cpp (+64/-0)
tests/utils/dbusserver.h (+48/-0)
tests/vs-thumb/CMakeLists.txt (+9/-0)
tests/vs-thumb/vs-thumb_test.cpp (+223/-0)
tests/whitespace/CMakeLists.txt (+9/-0)
tests/whitespace/check_whitespace.py (+114/-0)
tools/CMakeLists.txt (+0/-14)
tools/cachetool.cpp (+0/-37)
tools/imdump.cpp (+0/-34)
tools/lastfmtest.cpp (+0/-31)
tools/parse-settings.py (+123/-0)
tools/scaler.cpp (+0/-38)
tools/ubuntuservertest.cpp (+0/-28)
tsan-suppress (+2/-0)
valgrind-suppress (+133/-0)
| Changed in thumbnailer: | |
| importance: | Undecided → Critical |
| assignee: | nobody → Michi Henning (michihenning) |
| Changed in thumbnailer: | |
| status: | New → In Progress |
Revision history for this message
| Michi Henning (michihenning) wrote | #1 |
| Changed in thumbnailer: | |
| assignee: | Michi Henning (michihenning) → James Henstridge (jamesh) |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | #2 |
| Changed in thumbnailer: | |
| status: | In Progress → Fix Committed |
| Changed in thumbnailer: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
James's branch fixes the assertion failure, but we are still seeing the underlying apparmor failure, so the linked branch doesn't completely fix this yet.