Move service abstract base class check to launchers

Bug #1467439 reported by Elena Ezhova
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
oslo.service
Fix Released
Undecided
Elena Ezhova

Bug Description

The following check [1] is supposed to verify that a service that is being launched is an instance of service.ServiceBase abstract base class. However in some projects services are launched by instantiating a launcher (ServiceLauncher or ProcessLauncher) and then directly calling its launch_service method [2]. In this case the check [1] never executes.

That's why it has to be moved to launch_service methods of the both launcher classes.

[1] https://github.com/openstack/oslo.service/blob/master/oslo_service/service.py#L624-L626
[2] https://github.com/openstack/neutron/blob/master/neutron/wsgi.py#L251-L252

Elena Ezhova (eezhova)
description: updated
Changed in oslo.service:
assignee: nobody → Elena Ezhova (eezhova)
Revision history for this message
Elena Ezhova (eezhova) wrote :
Changed in oslo.service:
status: New → In Progress
Elena Ezhova (eezhova)
Changed in oslo.service:
status: In Progress → Fix Committed
Changed in oslo.service:
milestone: none → 0.3.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.